Closed
Bug 1473804
Opened 6 years ago
Closed 6 years ago
AutoTArray::SwapElements is unsound.
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files)
The attached testcase crashes. This hit me in bug 1455891, with the test-case from bug 1473694.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Comment on attachment 8990205 [details]
Don't lie to AutoTArray::EnsureCapacity.
Review ping Eric?
Attachment #8990205 -
Flags: review?(erahm)
Comment 3•6 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #2) > Comment on attachment 8990205 [details] > Don't lie to AutoTArray::EnsureCapacity. > > Review ping Eric? Apologies, for some reason this wasn't showing up in my dashboard.
Comment 4•6 years ago
|
||
Comment on attachment 8990205 [details] Don't lie to AutoTArray::EnsureCapacity. Eric Rahm [:erahm] (please no mozreview requests) has approved the revision. https://phabricator.services.mozilla.com/D1995
Attachment #8990205 -
Flags: review+
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8990205 [details]
Don't lie to AutoTArray::EnsureCapacity.
Thanks!
Attachment #8990205 -
Flags: review?(erahm)
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/a699694bd202 Don't lie to AutoTArray::EnsureCapacity. r=erahm
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/e0d9ee9dc6c0 Add doc comments to specified `float` and `clear` CSS property. r=emilio
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a699694bd202 https://hg.mozilla.org/mozilla-central/rev/e0d9ee9dc6c0
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•