1473820 - about:addons section holding the list gets a large dotted selection rectangle drawn, when clicked

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Cristian Fogel, QA [:cfogel]]

Attachment: Screen Shot 2018-07-06 at 10.33.56.png

[Affected versions]:
- Firefox 61.0.1, 62.0b6, 63.0a1 (2018-07-05) 

[Affected platforms]:
- macOS 10.13.4, Windows 10 x86, Ubuntu 16.04 x64

[Steps to reproduce]:
1. Launch firefox;
2. Click on the 3line-hamburger menu button;
3. Click on the Addons option;
4. Click on the Themes or plugins section;
5. Click on the div/section holding the themes.

[Expected result]:
- Nothing is selected/highlighted.

[Actual result]:
- The section is marked as selected.

 
[Additional notes]:
- on macOS, selection is present on clicking the Enable buttons as well;
- attached screenshot with the issue.

Comment 1

[Cristian Fogel, QA [:cfogel]]

On win10x64 it's not reproducible.
Will come up with a regression frame as soon as possible, managed to reproduce on 49.0a1 (2016-05-01) so it's not something new.

Comment 2

[Cristian Fogel, QA [:cfogel]]

Mozregression result:

Last good revision: 7723b15ea695 (2015-05-01)
First bad revision: 1e8d30cb367e (2015-05-02)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7723b15ea695&tochange=1e8d30cb367e

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Cristi Fogel [:cfogel] from comment #2)
> Mozregression result:
> 
> Last good revision: 7723b15ea695 (2015-05-01)
> First bad revision: 1e8d30cb367e (2015-05-02)

It looks like this range involved an addons manager UI redesign. This is presumably just a regression from that redesign.

--> Reclassifying.

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: screenshot from Nightly 2015-05-01 (before redesign)

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: screenshot from Nightly 2015-05-02 (after redesign), showing the unwanted focus rectangle

Comment 6

[Daniel Holbert [:dholbert]]

I think the redesign was:
> https://hg.mozilla.org/mozilla-central/rev/3b4fa5cc6210
> Richard Marti — Bug 989469 - Use new style for add-on manager. ui-r=mmasalaney r=mossop CLOSED TREE

Comment 7

[Pascal Chevrel:pascalc]

I can't reproduce in 64+ and I believe it was fixed by the redesign of the addons listing in bug 1490366, so marking as fixed.

Comment 8

[Cristian Fogel, QA [:cfogel]]

Agreed, marking as verified  as well. 
Confirmed with 64.0b11 and 65.0a1 (2018-11-20).