1473848 - Stop exporting locales not explicitly in CENTRAL_LOCALES, e.g., "mix"

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Ed Lee :Mardak]

flod, a recent strings import to activity-stream had some partially translated "mix" strings and our bundle step ends up showing:

 ✗ These locales were not in CENTRAL_LOCALES, but probably should be: mix 

It's not fatal, and we end up exporting (and packaging as we do for all strings):

https://searchfox.org/mozilla-central/source/browser/extensions/activity-stream/prerendered/locales/mix/activity-stream-strings.js#70-72

CENTRAL_LOCALES is a copy of https://hg.mozilla.org/mozilla-central/file/tip/browser/locales/l10n.toml and it seems like mix isn't ready to be built yet.

I can let others know to just ignore the message, or I could also just suppress the message by locally adding "mix" to CENTRAL_LOCALES even though it's not in l10n.toml.

Comment 1

[Francesco Lodolo [:flod]]

If possible, Locales that are not in l10n.toml should be ignored.

mix, in particular, is a locale working on Firefox for Android. They have Firefox enabled for shared parts (toolkit), and translated some strings in AS, which results in the file being exported.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4232

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/b5acb21f47f8519d383cd7f504b7415ecd091b4a
fix(prerender): Skip extra locales and convert extra message to yellow (#4232)

Fix Bug 1473848 - Stop exporting locales not explicitly in CENTRAL_LOCALES, e.g., "mix"

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/c8abaff6bcae