Closed
Bug 1473854
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 11823 - sensors: Stop passing undefined as an invalid SensorOptions value
Categories
(Testing :: web-platform-tests, enhancement, P4)
Testing
web-platform-tests
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 11823 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/11823 Details from upstream follow. Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> wrote: > sensors: Stop passing undefined as an invalid SensorOptions value > > While the undefined -> double conversion in WebIDL should indeed throw a > TypeError, we cannot forget we have a WebIDL dictionary (SensorOptions) in > the middle: > > {frequency: undefined} > > is essentially equivalent to > > {} > > so we do not actually throw a TypeError in this case at all.
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d2f887d77165eadcaab0053f8eea5f4989f0adf
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8cdab218e38ee34afed79f124e82caeb8b2cc0d
Assignee | ||
Comment 3•6 years ago
|
||
Ran 15 tests and 130 subtests OK : 15 PASS : 11 FAIL : 119
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d478b03baf90 [wpt PR 11823] - sensors: Stop passing undefined as an invalid SensorOptions value, a=testonly
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d478b03baf90
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•