1473866 - [Translate] Do not show rejected suggestions in string list and editor

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P2)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Have a string with rejected suggestion only (or rejected fuzzy import). Example here https://pontoon.mozilla.org/cs/amo-frontend/all-resources/?string=179910. This rejected suggestion is shown in the list on the left hand side. What's more, it's also prefilled in the input text area, when you view the string.

I find this confusing, because it may look like someone already worked on that string, which may:
- discourage contributors to actually work on it, as it looks like "done, only unreviewed",
- attract translators/managers attention, as for them it looks there is something to review.

Expected behaviour:
Rejected suggestions should never show anywhere except the history helper tab the less in such prominent parts of the UI like the list of strings or the input area.

May this be related to the recent bug, where no suggestions were shown?

Comment 1

[Matjaz Horvat [:mathjazz]]

We should have fixed this as part of bug 1377969. Previously, the behaviour was actually the same, except that the strings were treated as Suggested (blue icon).

I agree it should be fixed though.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1016

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/845f340672b04a800c240385ca20e3917218abb4
Fix bug 1473866 - Do not show rejected translations in strings list and editor. (#1016)

* Refactor some code.

* Fix bug 1473866 - Do not show rejected translations in strings list and editor.

* Hide translation from editor on reject.

* Use self instead of Pontoon.