14739 - use of uninitialized variable in nsNNTPProtocol.cpp

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[Colin Blake]

In mailnews/news/src/nsNNTPProtocol.cpp is a function
named nsNNTPProtocol::CloseSocket(). In this function is
the code:

        if (m_newsgroupList)
        {
                int status;
        nsresult rv;
       /* XXX - how/when to Release() this? */
        rv = m_newsgroupList->FinishXOVERLINE(status,&status);

Notice that status is passed in to FinishXOVERLINE before it has
been given a value.

Colin.

Comment 1

[Phil Peterson]

Reassign to mscott, cc sspitzer

Comment 2

[Scott MacGregor]

Yuck....I have a fix. Will get a code review from sspitzer and I'll try to check
this in today. It's so low risk that we should be able to get it approved.

Comment 3

[Scott MacGregor]

I checked in the fix for this problem.Good catch Colin.

Comment 4

[(not reading, please use [e-mail] instead)]

yes, thanks for finding this.

Comment 5

[ppandit]

The new code is the following. VERIFIED.

if (m_newsgroupList)
4996     {
4997         int status;
4998         nsresult rv;
4999        /* XXX - how/when to Release() this? */
5000         rv = m_newsgroupList->FinishXOVERLINE(0,&status);
5001         NS_ASSERTION(NS_SUCCEEDED(rv), "FinishXOVERLINE failed");
5002     }