1473902 - Wrong number in "more nodes" button in shadow root

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Julian Descottes [:jdescottes]]

STRs:
- go to https://juliandescottes.github.io/webcomponents-playground/test-too-many-light-dom/
- expand: body > test-component > slot
- scroll down to the first "more nodes" button

ER: Button should read "Show all 200 nodes"
AR: Button reads "Show one more node"

Comment 1

[Belén [:ladybenko]]

Attachment: Bug 1473902 - Wrong node count in 'show all nodes' button.

Review commit: https://reviewboard.mozilla.org/r/259400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259400/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8994861 [details]
Bug 1473902 - Wrong node count in 'show all nodes' button.

https://reviewboard.mozilla.org/r/259400/#review266582

Great find! Thanks for fixing this and adding a test.

::: devtools/server/actors/inspector/node.js:207
(Diff revision 1)
>      }
>  
>      // Normal counting misses ::before/::after.  Also, some anonymous children
>      // may ultimately be skipped, so we have to consult with the walker.
> -    if (numChildren === 0 || hasAnonChildren || isShadowHost(this.rawNode)) {
> +    if (numChildren === 0 || hasAnonChildren || isShadowHost(this.rawNode) ||
> +      isShadowAnonymous(this.rawNode)) {

I guess in theory we only need to check that for <slot> elements, but we can revisit in case we see a performance issue here.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/596379b80471
Wrong node count in 'show all nodes' button. r=jdescottes

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/596379b80471

Comment 5

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 62.0a1 (2018.07.06) on Windows 10 x64.
I can confirm this issue is fixed, I verified using Firefox 63.0b3 on Ubuntu 16.04 x64, Windows 10 x64 and Mac OS X 10.13.