1473908 - Record telemetry value for FrameLayerBuilder time

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement, P3)

Description

[Matt Woodrow (:mattwoodrow)]

We have existing probes recording total paint time, the displaylist subset, and the raster subset, but nothing for FrameLayerBuilder.

We should add this to keep track of improvements, since the PHASE_WEIGHT measurements record relative percentages and thus can be impacted by other wor.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: data-review-request.md

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1473908 - Add new telemetry measurement for recording time spent in FrameLayerBuilder.

Review commit: https://reviewboard.mozilla.org/r/255352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255352/

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 8990315 [details]
Bug 1473908 - Add new telemetry measurement for recording time spent in FrameLayerBuilder.

https://reviewboard.mozilla.org/r/255352/#review262200

Comment 4

[François Marier [:francois]]

Comment on attachment 8990315 [details]
Bug 1473908 - Add new telemetry measurement for recording time spent in FrameLayerBuilder.

https://reviewboard.mozilla.org/r/255352/#review262312

::: toolkit/components/telemetry/histogram-whitelists.json:926
(Diff revision 1)
>      "OSFILE_WORKER_LAUNCH_MS",
>      "OSFILE_WORKER_READY_MS",
>      "OSFILE_WRITEATOMIC_JANK_MS",
>      "PAGE_FAULTS_HARD",
>      "PAINT_BUILD_DISPLAYLIST_TIME",
> +    "PAINT_BUILD_LAYERS_TIME",

Why not just add the bug number to the probe in Histograms.json?

Comment 5

[François Marier [:francois]]

Comment on attachment 8990314 [details]
data-review-request.md

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json.

2) Is there a control mechanism that allows the user to turn the data collection on and off? 

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Matt Woodrow.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default ON in pre-release channels only.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.

Comment 6

[François Marier [:francois]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #1)
> Created attachment 8990314 [details]
> data-review-request.md

BTW, if you rename the file to .txt, it's slightly easier to review since it displays inline in Bugzilla. Sadly, that's not true of .md files yet (bug 1421032).

Comment 7

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8990315 [details]
Bug 1473908 - Add new telemetry measurement for recording time spent in FrameLayerBuilder.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255352/diff/1-2/

Comment 8

[François Marier [:francois]]

Comment on attachment 8990315 [details]
Bug 1473908 - Add new telemetry measurement for recording time spent in FrameLayerBuilder.

https://reviewboard.mozilla.org/r/255352/#review262360

Histograms.json looks good.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c599c23574d3
Add new telemetry measurement for recording time spent in FrameLayerBuilder. r=bas,francois

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c599c23574d3