1473915 - Set up infrastructure so we can move the manifest out of tree

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Comment 1

[Ahilya Sinha [:cactusmachete]]

Attachment: Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

Currently breaks maniest update and the upload task, which will
require some more looking into to fix.

Review commit: https://reviewboard.mozilla.org/r/255368/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255368/

Comment 2

[James Graham [:jgraham]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

https://reviewboard.mozilla.org/r/255368/#review262506

This is starting to look proming to me. I would like gps or someone on the build team to check the changes to the packaging to include the downloaded manifest. Otherwise I think it's looking reasonable; have you made a try run starting from a manifestless tree yet?

::: testing/web-platform/manifestupdate.py:50
(Diff revision 1)
>  
>  
>  def _update(logger, test_paths, rebuild):
>      for url_base, paths in test_paths.iteritems():
>          manifest_path = os.path.join(paths["metadata_path"], "MANIFEST.json")
> -        if rebuild:
> +        if rebuild: 

You accidentially added a whitespace error.

Comment 3

[Ahilya Sinha [:cactusmachete]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255368/diff/1-2/

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

I know the topic of WPT manifests has been discussed a bit recently. I'm not sure if things have changed and don't want to waste time reviewing bitrotted code. Please re-request review if this patch is still needing my review and I'll try to get to it promptly.

And sorry for the delay on weighing in on WPT. I was dealing with hg.mo datacenter migration chaos for the past several weeks and got lagged on nearly everything else :/

Comment 5

[Ahilya Sinha [:cactusmachete]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255368/diff/2-3/

Comment 6

[James Graham [:jgraham]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

https://reviewboard.mozilla.org/r/255368/#review268244

::: testing/web-platform/mach_commands_base.py:11
(Diff revision 3)
>  
>  
>  def create_parser_wpt():
>      from wptrunner import wptcommandline
> -    return wptcommandline.create_parser(["fennec", "firefox", "chrome", "edge", "servo"])
> +    parser = wptcommandline.create_parser(["fennec", "firefox", "chrome", "edge", "servo"])
> +    parser.add_argument(

Let's put this directly in wptcommand line.

::: testing/web-platform/manifestdownload.py:67
(Diff revision 3)
>  
>      for revision in commits:
> +        try:
> -        req = requests.get(cset_url.format(changeset=revision),
> +            req = requests.get(cset_url.format(changeset=revision),
> -                           headers={'Accept': 'application/json'})
> +                               headers={'Accept': 'application/json'})
> +        except :

Don't use base `except`, always list an exception (even just `Exception`). In this case you probably want the base `requests` exception type.

::: testing/web-platform/manifestdownload.py:75
(Diff revision 3)
>          result = req.json()
>          [cset] = result['pushes'].values()[0]['changesets']
> +
> +        try:
> -        req = requests.get(tc_url.format(changeset=cset))
> +            req = requests.get(tc_url.format(changeset=cset))
> +        except :

Bare except again.

::: testing/web-platform/manifestdownload.py:193
(Diff revision 3)
>      success = download_from_taskcluster(logger, wpt_dir, repo_root, force)
> +
> +    if not success:
> +        logger.info("Could not download manifests.")
> +        logger.info("Generating from scratch instead.")
> +        distutils.dir_util.mkpath(os.path.join(wpt_dir, "meta"))

I don't think you need distutils here, just os.mkdirs should do?

::: testing/web-platform/manifestdownload.py:197
(Diff revision 3)
> +        logger.info("Generating from scratch instead.")
> +        distutils.dir_util.mkpath(os.path.join(wpt_dir, "meta"))
> +        distutils.dir_util.mkpath(os.path.join(wpt_dir, "mozilla", "meta"))
> +
> +    generate_config(wpt_dir)
> +    success |= update_manifest(logger, wpt_dir, update)

I think we should return success if we managed up generate the manifest even if we failed to download it.

::: testing/web-platform/manifestupdate.py:49
(Diff revision 3)
> -
>      return _update(logger, test_paths, rebuild)
>  
>  
>  def _update(logger, test_paths, rebuild):
>      for url_base, paths in test_paths.iteritems():

PR 12227 upstream has a commit that puts the ManifestLoader into the manifest directory rather than into wptrunner. If that lands, it could be used to simplify some of the code here, but it's not critical.

::: testing/web-platform/moz.build
(Diff revision 3)
>  # vim: set filetype=python:
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> -WEB_PLATFORM_TESTS_MANIFESTS += [

There are a few other bits in the build system that should go:

https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/frontend/context.py#1880

https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/frontend/context.py#910

https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/testing.py#285

Comment 7

[Ahilya Sinha [:cactusmachete]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255368/diff/3-4/

Comment 8

[Code Review Bot [:reviewbot]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

https://reviewboard.mozilla.org/r/255368/#review268894


Code analysis found 2 defects in this patch:
 - 2 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python/etc)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: testing/mozbase/moztest/moztest/resolve.py:434
(Diff revision 4)
> +        wptrunner_path = os.path.join(wpt_path, "tests", "tools", "wptrunner")
> +        sys.path.insert(0, wpt_path)
> +        sys.path.insert(0, wptrunner_path)
> +        import manifestdownload
> +        import wptrunner
> +        from wptrunner.wptrunner import testloader

Error: 'wptrunner.wptrunner.testloader' imported but unused [flake8: F401]

::: testing/mozbase/moztest/moztest/resolve.py:440
(Diff revision 4)
> +
> +        man_path = os.path.join(self.objdir, "_tests", "web-platform")
> +        manifestdownload.run(man_path, os.getcwd(), force=True)
> +
> +        kwargs = {"config": os.path.join(self.objdir, "_tests", "web-platform",
> +                            "wptrunner.local.ini"),

Error: Continuation line under-indented for visual indent [flake8: E128]

Comment 9

[James Graham [:jgraham]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

https://reviewboard.mozilla.org/r/255368/#review268250

::: testing/web-platform/manifestdownload.py:29
(Diff revision 3)
>  
>  def git_commits(repo_root):
>      git = vcs.Git.get_func(repo_root)
>      for item in git("log", "--format=%H", "-n50", "testing/web-platform/tests",
>                      "testing/web-platform/mozilla/tests").splitlines():
>          yield git("cinnabar", "git2hg", item)

Need to run `.strip()` on this to remove the trailing newline.

::: testing/mozbase/moztest/moztest/resolve.py:289
(Diff revision 4)
>  
>      def __init__(self, all_tests, test_defaults=None):
>          self._tests_by_path = OrderedDefaultDict(list)
>          self._tests_by_flavor = defaultdict(set)
>          self._test_dirs = set()
> +        self.objdir = os.path.abspath(os.path.join(all_tests, os.pardir))

This class seems to use `_` prefixed member attributes.

::: testing/mozbase/moztest/moztest/resolve.py:416
(Diff revision 4)
>                  yield test
>  
> +    def is_wpt_path(self, path):
> +        if path is None:
> +            return True
> +        if path.startswith("testing/web-platform/tests"):

I wonder if this works on Windows; do we know that the paths are normalised to have `/` as the seperator. The simplest solution is to do `path = path.replace(os.path.sep, "/")`

::: testing/mozbase/moztest/moztest/resolve.py:420
(Diff revision 4)
> +            return True
> +        if path.startswith("testing/web-platform/tests"):
> +            return True
> +        if path.startswith("testing/web-platform/mozilla/tests"):
> +            return True
> +        if path in ("testing", "testing/", "testing/*"):

This isn't every case, right? Something like `re.match(r"testing(?:/web-platform)?(?:/mozilla(?:/tests)?|tests/)?/?\*?)` seems like it would work, but there must be a simpler way…

Ah, looking above I notice `mozpath.match`; I bet that does what we want. Yeah https://searchfox.org/mozilla-central/source/third_party/python/compare-locales/compare_locales/mozpath.py#96

Looks like if mozpath.match("testing/web-platform/tests", path) or mozpath.match("testing/web-platform/mozilla/tests", path) would do the right thing.

::: testing/mozbase/moztest/moztest/resolve.py:428
(Diff revision 4)
> +
> +    def add_wpt_manifest_data(self):
> +        if self.wpt_loaded:
> +            return
> +
> +        wpt_path = os.path.join(os.getcwd(), "testing", "web-platform")

If we need the `topsrcdir` we should pass that in when constructing the class, or something, because this will break if someone runs mach from somewhere else (like `cd testing/web-platform && ../../mach test`)

::: testing/mozbase/moztest/moztest/resolve.py:430
(Diff revision 4)
> +        if self.wpt_loaded:
> +            return
> +
> +        wpt_path = os.path.join(os.getcwd(), "testing", "web-platform")
> +        wptrunner_path = os.path.join(wpt_path, "tests", "tools", "wptrunner")
> +        sys.path.insert(0, wpt_path)

I know we don't do this much, but maybe write a wrapper like

```
class SysPath(object):
    def __init__(self, *paths):
        self.paths = paths
    def __enter__(self):
        self.old_path = sys.path[:]
        self.old_modules = sys.modules.copy()
        sys.path = list(self.paths) + sys.path
    def __exit__(self, *args):
        sys.path = self.old_path
        sys.modules = self.old_modules
```

Which you can then use as 

```
with SysPath(wpt_path, wptrunner_path):
    # Do stuff with the altered sys.path
```

Just makes the changes a bit more localised.

::: testing/web-platform/manifestdownload.py:27
(Diff revision 4)
>  
>  
>  def git_commits(repo_root):
>      git = vcs.Git.get_func(repo_root)
>      for item in git("log", "--format=%H", "-n50", "testing/web-platform/tests",
> -                    "testing/web-platform/mozilla/tests").splitlines():
> +                    "testing/web-platform/mozilla/tests").splitlines().strip():

I think you need to `strip()` the output of `git("cinnabar", "git2hg", item)`, not this.

::: testing/web-platform/manifestdownload.py:88
(Diff revision 4)
>      return ("https://index.taskcluster.net/v1/task/gecko.v2.mozilla-central."
>              "latest.source.manifest-upload")
>  
>  
>  def download_manifest(logger, wpt_dir, commits_func, url_func, force=False):
> -    if not force and not should_download(logger, os.path.join(wpt_dir, "meta", "MANIFEST.json")):
> +    man_path = os.path.join(wpt_dir, "meta", "MANIFEST.json")

In general I think I would find `manifest_path` easier to understand.

::: testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py:73
(Diff revision 4)
>                          help="Don't capture stdio and write to logging")
>      parser.add_argument("--no-fail-on-unexpected", action="store_false",
>                          default=True,
>                          dest="fail_on_unexpected",
>                          help="Exit with status code 0 when test expectations are violated")
> +    parser.add_argument("--no-update", action="store_false", dest="update", default=True,

I just realised that `--no-manifest-update` already exists.

Comment 10

[Ahilya Sinha [:cactusmachete]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255368/diff/4-5/

Comment 11

[James Graham [:jgraham]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

https://reviewboard.mozilla.org/r/255368/#review269076

::: testing/mozbase/moztest/moztest/resolve.py:427
(Diff revisions 4 - 5)
>  
>      def add_wpt_manifest_data(self):
> -        if self.wpt_loaded:
> +        if self._wpt_loaded:
>              return
>  
> -        wpt_path = os.path.join(os.getcwd(), "testing", "web-platform")
> +        src_dir = os.path.abspath(os.path.join(self._objdir, os.pardir))

Unfortunatley not; you can configure the objdir to be anywhere. You really do need to pass in the `topsrcdir` to this class.

::: testing/web-platform/mach_commands.py:373
(Diff revisions 4 - 5)
>              for item in params["test_objects"]:
>                  params["include"].append(item["name"])
>              del params["test_objects"]
>  
>          self.wpt_manifest_download(**params)
> +        params["manifest_update"]=False

Space before and after `=`

::: testing/web-platform/manifestdownload.py:69
(Diff revisions 4 - 5)
>              req = requests.get(cset_url.format(changeset=revision),
>                                 headers={'Accept': 'application/json'})
>          except requests.exceptions.RequestExceptions :
>              return False
>  
> +        if req.status_code==404:

More space.

Do we care about 404 specifically or should we check `if request.status_code < 200 or request.status_code >= 300`?

Comment 12

[Ahilya Sinha [:cactusmachete]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

https://reviewboard.mozilla.org/r/255368/#review269076

> More space.
> 
> Do we care about 404 specifically or should we check `if request.status_code < 200 or request.status_code >= 300`?

Maybe just check req.raise_for_status() instead? That covers all bases, I think.

Comment 13

[Ahilya Sinha [:cactusmachete]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255368/diff/5-6/

Comment 14

[James Graham [:jgraham]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

https://reviewboard.mozilla.org/r/255368/#review269338

Stll needs a review from the build peers.

Can you please update the commit message to detail the changes in this patch? The usual format is summary line / blank line / longer description of changes.

Comment 15

[Ahilya Sinha [:cactusmachete]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255368/diff/6-7/

Comment 16

[James Graham [:jgraham]]

Are you going to have time to review this before mozreview is shut down, or should I recreate the review on phabricator?

Comment 17

[Xidorn Quan [:xidorn] UTC+11]

I guess you should probably recreate a phabricator review request given that mozreview has been down.

Also, I would hope we fix this or come to an alternative solution as soon as possible. Currently adding web-platform test is a pain when trying to submit review request to phabricator due to bug 1446555.

Comment 18

[Karl Tomlinson (:karlt)]

No need to create a phabricator request.  Revisions are available at
https://hg.mozilla.org/mozreview/gecko/log?rev=1473915
and probably easier to review from there because interdiffs are
easy to generate.  The reviewer can push to phabricator if they
prefer to make comments there.

Comment 19

[James Graham [:jgraham]]

I'm not sure if gps is on PTO or swamped, but this has now been taken out of the builds review queue and in his queue for three weeks without any activity. With increased usage of wpt and the change in review tools, the problems addressed in this patch are becoming more urgent so it would be good to find some way to get build peer review on the propsosed changes.

Comment 20

[Chris Cooper [:coop] (he/him)]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

kmoir can help with prioritization here.

Comment 21

[Kim Moir [:kmoir] ET]

I talked to gps today and he said he will review it tomorrow.

Comment 22

[Nathan Froyd [:froydnj]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

(In reply to Kim Moir [:kmoir] ET from comment #21)
> I talked to gps today and he said he will review it tomorrow.

Moving this back to gps, then, to remove it from the shared queue.

Comment 23

[Gregory Szorc [:gps]]

Attachment: Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree

Changes the wpt manifest path to the topobjdir instead so it can be moved out of tree.
Other changes so that the manifest download and update, and |mach wpt| and |mach test <wpt-test>| work with the new path.
The manifest is also downloaded and updated when creating the tests-archive to ensure that it exists when we run tests on TC.

MozReview-Commit-ID: Fp6UsKJjhTU

Comment 24

[Gregory Szorc [:gps]]

Attachment: Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree

Changes the wpt manifest path to the topobjdir instead so it can be moved out of tree.
Other changes so that the manifest download and update, and |mach wpt| and |mach test <wpt-test>| work with the new path.
The manifest is also downloaded and updated when creating the tests-archive to ensure that it exists when we run tests on TC.

MozReview-Commit-ID: Fp6UsKJjhTU

Comment 25

[Gregory Szorc [:gps]]

Comment on attachment 8990332 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree,

I left a review in Phabricator.

Comment 26

[Gregory Szorc [:gps]]

Comment on attachment 9007355 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree

Gregory Szorc [:gps] has approved the revision.

Comment 27

[Gregory Szorc [:gps]]

Comment on attachment 9007355 [details]
Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree

Not sure why the review flags got in a bad state.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd80de19f142
Set up infra so we can move the wpt-manifest out of tree r=gps

Comment 29

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13075 for changes under testing/web-platform/tests

Comment 30

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 31

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe66be438c57
Backed out changeset dd80de19f142 for mb failures in  testing/mozbase/moztest/tests/test_resolve.py CLOSED TREE

Comment 32

[Stefan Hindli [:stefan_hindli]]

Backed out changeset dd80de19f142 (Bug 1473915) for mb failures in testing/mozbase/moztest/tests/test_resolve.py CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception&classifiedState=unclassified&fromchange=1e4443c0469155afcd2cb93ca0c9a6bf9b729626&selectedJob=200189997

https://treeherder.mozilla.org/logviewer.html#?job_id=200189997&repo=autoland&lineNumber=5053


[task 2018-09-19T15:02:28.814Z] 15:02:28     INFO - 
[task 2018-09-19T15:02:28.815Z] 15:02:28     INFO - TEST-PASS | /css/cssom-view/scrollIntoView-smooth.html | Smooth scrollIntoView should scroll the element to the 'nearest' position 
[task 2018-09-19T15:02:28.815Z] 15:02:28     INFO - TEST-UNEXPECTED-TIMEOUT | /css/cssom-view/scrollIntoView-smooth.html | Smooth scrollIntoView should scroll the element to the 'start' position - Test timed out
[task 2018-09-19T15:02:28.816Z] 15:02:28     INFO - 
[task 2018-09-19T15:02:28.817Z] 15:02:28     INFO - TEST-UNEXPECTED-NOTRUN | /css/cssom-view/scrollIntoView-smooth.html | Smooth scrollIntoView should scroll the element to the 'center' position - expected PASS
[task 2018-09-19T15:02:28.818Z] 15:02:28     INFO - 
[task 2018-09-19T15:02:28.818Z] 15:02:28     INFO - TEST-UNEXPECTED-NOTRUN | /css/cssom-view/scrollIntoView-smooth.html | Smooth scrollIntoView should scroll the element to the 'end' position - expected PASS
[task 2018-09-19T15:02:28.819Z] 15:02:28     INFO - TEST-UNEXPECTED-TIMEOUT | /css/cssom-view/scrollIntoView-smooth.html | expected OK
[task 2018-09-19T15:02:28.819Z] 15:02:28     INFO - TEST-INFO took 30388ms
[task 2018-09-19T15:02:28.868Z] 15:02:28     INFO - PID 2524 | 1537369348858	Marionette	INFO	Stopped listening on port 2828
[task 2018-09-19T15:02:29.884Z] 15:02:29     INFO - PID 2524 | [2524, Main Thread] WARNING: NS_ENSURE_TRUE(mDB) failed: file /builds/worker/workspace/build/src/netwerk/cache/nsDiskCacheDeviceSQL.cpp, line 1422
[task 2018-09-19T15:02:29.900Z] 15:02:29     INFO - PID 2524 | [2524, Main Thread] WARNING: NS_ENSURE_TRUE(maybeContext) failed: file /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp, line 866
[task 2018-09-19T15:02:30.815Z] 15:02:30     INFO - PID 2524 | [2524, Main Thread] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/DOMEventTargetHelper.h, line 146
[task 2018-09-19T15:02:30.823Z] 15:02:30     INFO - PID 2524 | [2524, Main Thread] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/DOMEventTargetHelper.h, line 146
[task 2018-09-19T15:02:30.960Z] 15:02:30     INFO - PID 2524 | --DOMWINDOW == 19 (0xe6fba160) [pid = 2524] [serial = 1] [outer = (nil)] [url = resource://gre-resources/hiddenWindow.html]
[task 2018-09-19T15:02:30.961Z] 15:02:30     INFO - PID 2524 | --DOMWINDOW == 18 (0xe4824400) [pid = 2524] [serial = 15] [outer = (nil)] [url = about:blank]
[task 2018-09-19T15:02:30.962Z] 15:02:30     INFO - PID 2524 | --DOMWINDOW == 17 (0xe4857ca0) [pid = 2524] [serial = 6] [outer = (nil)] [url = about:blank]
[task 2018-09-19T15:02:30.964Z] 15:02:30     INFO - PID 2524 | --DOCSHELL 0xe18ab400 == 9 [pid = 2524] [id = {64b26032-d174-4aee-8c56-7be5e38f7eb6}]
[task 2018-09-19T15:02:30.964Z] 15:02:30     INFO - PID 2524 | --DOCSHELL 0xe5adcc00 == 8 [pid = 2524] [id = {96996c2c-1595-42a9-9fea-3d70cbfc2a7a}]
[task 2018-09-19T15:02:30.966Z] 15:02:30     INFO - PID 2524 | --DOCSHELL 0xe4758800 == 7 [pid = 2524] [id = {90459bab-1bb0-4c9e-8b48-93c02615e8e2}]
[task 2018-09-19T15:02:30.967Z] 15:02:30     INFO - PID 2524 | --DOCSHELL 0xe820d400 == 6 [pid = 2524] [id = {feb3b142-6d27-4a7e-9695-846f807e71e5}]
[task 2018-09-19T15:02:30.968Z] 15:02:30     INFO - PID 2524 | --DOCSHELL 0xe3fd8c00 == 5 [pid = 2524] [id = {d9c7c110-c99d-4622-b763-45e08dfda954}]
[task 2018-09-19T15:02:30.968Z] 15:02:30     INFO - PID 2524 | --DOCSHELL 0xe4750800 == 4 [pid = 2524] [id = {92d9a050-c921-42ef-9af7-5df3883d895a}]
[task 2018-09-19T15:02:30.968Z] 15:02:30     INFO - PID 2524 | --DOCSHELL 0xe346b400 == 3 [pid = 2524] [id = {4dae689c-c2d7-4971-ac27-85787d71c176}]
[task 2018-09-19T15:02:30.968Z] 15:02:30     INFO - PID 2524 | --DOCSHELL 0xe0bf2800 == 2 [pid = 2524] [id = {ebd5241a-c848-4b09-8f88-fbcf4cc68cd0}]
[task 2018-09-19T15:02:30.969Z] 15:02:30     INFO - PID 2524 | --DOCSHELL 0xe4820400 == 1 [pid = 2524] [id = {4c6c7545-ce4e-4a4d-8966-d0fd4b809884}]
[task 2018-09-19T15:02:30.972Z] 15:02:30     INFO - PID 2524 | --DOCSHELL 0xddec3c00 == 0 [pid = 2524] [id = {f7da9414-b1bc-41de-af87-056eb163c2c5}]
[task 2018-09-19T15:02:30.977Z] 15:02:30     INFO - PID 2524 | --DOMWINDOW == 16 (0xe0507000) [pid = 2524] [serial = 183] [outer = (nil)] [url = about:blank]
[task 2018-09-19T15:02:30.978Z] 15:02:30     INFO - PID 2524 | --DOMWINDOW == 15 (0xdecf7820) [pid = 2524] [serial = 181] [outer = (nil)] [url = http://web-platform.test:8000/css/cssom-view/scrollIntoView-smooth.html]
[task 2018-09-19T15:02:30.979Z] 15:02:30     INFO - PID 2524 | --DOMWINDOW == 14 (0xe04ee000) [pid = 2524] [serial = 25] [outer = (nil)] [url = http://web-platform.test:8000/testharness_runner.html]
[task 2018-09-19T15:02:30.983Z] 15:02:30     INFO - PID 2524 | --DOMWINDOW == 13 (0xe3c5da60) [pid = 2524] [serial = 12] [outer = (nil)] [url = http://web-platform.test:8000/testharness_runner.html]
[task 2018-09-19T15:02:30.983Z] 15:02:30     INFO - PID 2524 | [2524, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 564
[task 2018-09-19T15:02:30.984Z] 15:02:30     INFO - PID 2524 | [2524, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 564
[task 2018-09-19T15:02:30.984Z] 15:02:30     INFO - PID 2524 | [2524, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 564
[task 2018-09-19T15:02:30.985Z] 15:02:30     INFO - PID 2524 | [2524, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 564
[task 2018-09-19T15:02:30.985Z] 15:02:30     INFO - PID 2524 | [2524, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 564
[task 2018-09-19T15:02:30.986Z] 15:02:30     INFO - PID 2524 | [2524, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 564
[task 2018-09-19T15:02:30.986Z] 15:02:30     INFO - PID 2524 | [2524, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 564
[task 2018-09-19T15:02:30.986Z] 15:02:30     INFO - PID 2524 | [2524, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 564
[task 2018-09-19T15:02:30.987Z] 15:02:30     INFO - PID 2524 | [2524, Main Thread] WARNING: '!mMainThread', file /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp, line 564
[task 2018-09-19T15:02:30.987Z] 15:02:30     INFO - PID 2524 | --DOMWINDOW == 12 (0xe5aa5160) [pid = 2524] [serial = 3] [outer = (nil)] [url = chrome://browser/content/browser.xul]
[task 2018-09-19T15:02:30.988Z] 15:02:30     INFO - PID 2524 | --DOMWINDOW == 11 (0xdf66fb80) [pid = 2524] [serial = 29] [outer = (nil)] [url = about:newtab]

Comment 33

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 34

[James Graham [:jgraham]]

Attachment: Bug 1473915 - Set up infra so we can move the wpt-manifest out of tree

Changes the wpt manifest path to the topobjdir instead so it can be
moved out of tree.

Other changes so that the manifest download and
update, and |mach wpt| and |mach test <wpt-test>| work with the new
path.

The manifest is also downloaded and updated when creating the
tests-archive to ensure that it exists when we run tests on TC.

MozReview-Commit-ID: Fp6UsKJjhTU

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcb3abf64101
Set up infra so we can move the wpt-manifest out of tree r=gps

Comment 36

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 37

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fcb3abf64101

Comment 38

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 39

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13075
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/e_8r4r6AS2-0q1rty-liUg)