1473933 - Remove xpinstallConfirm.xul

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P3)

Description

[:Paolo Amadini]

This is part of the work tracked in bug 1470830.

Comment 1

[Dão Gottwald [:dao]]

Firefox doesn't use xpinstallConfirm.xul anymore. We might want to remove support for this from AddonManager.jsm. Besides, xpinstallConfirm.xul already loads xpinstallConfirm.css as a document stylesheet, so that could just be dropped from xpinstallItem.xml.

Comment 2

[Brian Grinstead [:bgrins]]

Dropping it from the XUL file sounds reasonable

Comment 3

[Tim Nguyen :ntim]

CC'ing Kris as he might be interested in this.

Comment 4

[Kris Maglione [:kmag]]

This can just go away. Thunderbird and Seamonkey probably still use it, but they can move it to comm-central.

Comment 5

[Jorg K (CEST = GMT+2)]

Thanks, I'll add Richard.

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Jorg K (GMT+2) from comment #5)
> Thanks, I'll add Richard.

Thanks, would one of you be able to take this bug? You probably also want to remove the <resources> as per Comment 1 since it seems like it may work just as well, and we're working towards removing <resources> support anyway.

Comment 7

[Kris Maglione [:kmag]]

I'll do it.

Comment 8

[Kris Maglione [:kmag]]

Attachment: Bug 1473933: Remove xpinstallConfirm dialog. r=aswan

Comment 9

[Andrew Swan [:aswan]]

Comment on attachment 9011969 [details]
Bug 1473933: Remove xpinstallConfirm dialog. r=aswan

Andrew Swan [:aswan] has approved the revision.

Comment 10

[Kris Maglione [:kmag]]

Attachment: Bug 1473933: Part 2 - Remove more unused code. r=aswan

Comment 11

[Andrew Swan [:aswan]]

Comment on attachment 9011996 [details]
Bug 1473933: Part 2 - Remove more unused code. r=aswan

Andrew Swan [:aswan] has approved the revision.

Comment 12

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9a9e40ab5ce6d56a975ca407288169917e95d0d
Bug 1473933: Remove xpinstallConfirm dialog. r=aswan

https://hg.mozilla.org/integration/mozilla-inbound/rev/21b679ea5cb6678cdc759407ca89049e5e1b51bd
Bug 1473933: Part 2 - Remove more unused code. r=aswan

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d9a9e40ab5ce
https://hg.mozilla.org/mozilla-central/rev/21b679ea5cb6