1473942 - Addon opens url after installation fired after updating Firefox

Status: RESOLVED INVALID

(WebExtensions :: General, defect)

Description

[Account Disabled]

User Agent: Mozilla/5.0 (Linux; Android 7.0; TRT-L21A Build/HUAWEITRT-L21A) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.109 Mobile Safari/537.36

Steps to reproduce:

I get this mail.
Also I know other users have this issue too, But I don't have this issue in my PC.


Hello! I'm one of the Firefox users that also uses your add-on named Popup Blocker Ultimate. So far I find this add-on effective that for every popup, I would get the notification of the pop-ups getting blocked. I do find one issue though, but I hope you'll hear me nicely on this.

Lately I noticed something that's quite odd when I'm updating my Firefox nowadays. For some reason, after I'm opening my Firefox after doing the updates, one of the new tabs happened to be your site. So I checked your add-ons to see if I updated it, but I don't think so. I'm wondering if it have to do with the Firefox update removing some preferences to your add-on or something? I meant, it's kinda odd seeing the page pops up every time I'm updating my Firefox.

I did intend to say that issue on the review thing, but the guidelines says that was not the place to do that, so I have removed that from the review, but I guess you have noticed as I'm in the middle of writing this. I'm using Firefox 61.0.1 (64-bit), and I'm using Windows 8.1 (also 64-bit). I hope this will be fixed soon :)

Sincerely



Expected results:

My new tab must show once after installation.
I used your API.

Comment 1

[Andrew Swan [:aswan]]

The extension is creating a new tab unconditionally from a listener for runtime.onInstalled.
But that event is fired in a few different cases, including when the browser is updated:
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime/onInstalled

Comment 2

[Account Disabled]

There is no need to be fired on Firefox Update.
It is annoying for users.
Sincerely

Comment 3

[Andrew Swan [:aswan]]

This is a bug in the extension, you'll have to talk to the extension author and ask them to update the extension to use the onInstalled event as it is documented.

Comment 4

[Gingerbread Man]

(In reply to Andrew Swan [:aswan] from comment #3)
> This is a bug in the extension, you'll have to talk to the extension author

The reporter is the extension author.

Comment 5

[Account Disabled]

The issue is that why this function should fire after browser updates?
There is no need to fire it in that case.
Sincerely

Comment 6

[Andrew Swan [:aswan]]

(In reply to Mojtaba Daneshi from comment #5)
> The issue is that why this function should fire after browser updates?
> There is no need to fire it in that case.

This API was originally created in Google Chrome and duplicated in Firefox for compatibility.
There are multiple events that extensions might be interested in, it could have been implemented with separate events but now that this is the documented behavior, we can't change it without breaking existing extensions.  Please read the documentation, you can use the reason property on the details object passed to the listener to distinguish the different cases.