Closed
Bug 1474027
Opened 6 years ago
Closed 6 years ago
Naming and setters/getters in RectAbsolute are somewhat confusing
Categories
(Core :: Graphics, enhancement)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: bas.schouten, Assigned: bas.schouten)
Details
Attachments
(1 file)
The members are called x1, x2, y1, y2, the setters use the (in my opinion better) left/right/top/bottom terminology. I'd like to consolidate this all a little and make accessing the different values a little less cumbersome. Here's a suggestion.
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8990471 [details] Bug 1474027: Rename RectAbsolute members and make them easier to access. https://reviewboard.mozilla.org/r/255546/#review262362
Attachment #8990471 -
Flags: review?(botond) → review+
Pushed by bschouten@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ed0140d52100 Rename RectAbsolute members and make them easier to access. r=botond
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ed0140d52100
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•