Closed
Bug 1474045
Opened 6 years ago
Closed 6 years ago
Make nsIScriptGlobalObject::HandleScriptError non-virtual
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
There's no reason for it to be virtual.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 2•6 years ago
|
||
Kyle, you saw the Phabricator review ping, right?
Flags: needinfo?(kyle)
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8990484 [details] Bug 1474045. Make nsIScriptGlobalObject::HandleScriptError non-virtual. r=qdot Kyle Machulis [:qdot] [:kmachulis] (if a patch has no decent commit message, automatic r-) has approved the revision. https://phabricator.services.mozilla.com/D2018
Attachment #8990484 -
Flags: review+
|
||
Comment 4•6 years ago
|
||
Sorry about that, have some mail filters I need to fix.
Flags: needinfo?(kyle)
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4c266d09250c Make nsIScriptGlobalObject::HandleScriptError non-virtual. r=qdot
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4c266d09250c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•