Closed Bug 1474045 Opened Last year Closed Last year

Make nsIScriptGlobalObject::HandleScriptError non-virtual

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

There's no reason for it to be virtual.
Priority: -- → P2
Kyle, you saw the Phabricator review ping, right?
Flags: needinfo?(kyle)
Comment on attachment 8990484 [details]
Bug 1474045.  Make nsIScriptGlobalObject::HandleScriptError non-virtual.  r=qdot

Kyle Machulis [:qdot] [:kmachulis] (if a patch has no decent commit message, automatic r-) has approved the revision.

https://phabricator.services.mozilla.com/D2018
Attachment #8990484 - Flags: review+
Sorry about that, have some mail filters I need to fix.
Flags: needinfo?(kyle)
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c266d09250c
Make nsIScriptGlobalObject::HandleScriptError non-virtual.  r=qdot
https://hg.mozilla.org/mozilla-central/rev/4c266d09250c
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.