Closed
Bug 1474082
Opened 6 years ago
Closed 6 years ago
passing null to cal.l10n.getString() as params causes an error
Categories
(Calendar :: Internal Components, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
6.2
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file)
|
4.30 KB,
patch
|
MakeMyDay
:
review+
Fallen
:
approval-calendar-beta+
Fallen
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
There were two instances where null is passed as aParams to cal.l10n.getString(). I fixed those two, a random indent issue I found, and played on the safe side and fixed cal.l10n.getString() to accept null as well.
|
Assignee | |
Comment 1•6 years ago
|
||
This will have to go to ESR as well, if we are lucky before the release.
Attachment #8990496 -
Flags: review?(makemyday)
Attachment #8990496 -
Flags: approval-calendar-esr+
Attachment #8990496 -
Flags: approval-calendar-beta+
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8990496 [details] [diff] [review] Fix - v1 Review of attachment 8990496 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, looks good. r=me
Attachment #8990496 -
Flags: review?(makemyday) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/2b5ea3a0a96e Allow passing null for cal.l10n.getString()'s aParams. r=MakeMyDay
|
||
Updated•6 years ago
|
Target Milestone: --- → 6.5
|
|
||
Comment 4•6 years ago
|
||
TB 60 beta 10, Cal 6.2: https://hg.mozilla.org/releases/comm-beta/rev/07e328042925561f1dbd59623cdd4422f434fddf Beta (TB 62, Cal 6.4): https://hg.mozilla.org/releases/comm-beta/rev/5dc8df0b1121762d37c931ed0f591c6e63165513
Target Milestone: 6.5 → 6.2
|
|
||
Comment 5•6 years ago
|
||
Make that: TB 60 beta 10, Cal 6.2 (BETA_60_CONTINUATION branch): https://hg.mozilla.org/releases/comm-beta/rev/07e328042925561f1dbd59623cdd4422f434fddf
You need to log in
before you can comment on or make changes to this bug.
Description
•