Closed Bug 1474087 Opened Last year Closed Last year

Remove the <resources> from mail/components/im/content/imconversation.xml

Categories

(Thunderbird :: Instant Messaging, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 63.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1474069 will remove support for XBL <resources>, meaning that all XBL
stylesheets should become regular stylesheets, similarly to the dependencies of
bug 1470830.

mail/components/im/content/imconversation.xml has one <resources> that should be removable.
Attached patch imconversation-resource.patch (obsolete) — Splinter Review
I see no negative effect removing this <resources>. Additionally I set -moz-window-dragging: no-dragging; to stop the ability to drag the window in this box.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8990500 - Flags: review?(florian)
I found a <resources> in imtooltip.xml. Removed this too.

To make it simpler, I removed the content/imtooltip.css and moved the rule to skin/imtooltip.css (where one of the selectors was already).
Attachment #8990500 - Attachment is obsolete: true
Attachment #8990500 - Flags: review?(florian)
Attachment #8990535 - Flags: review?(florian)
Comment on attachment 8990535 [details] [diff] [review]
im-resource.patch

Review of attachment 8990535 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8990535 - Flags: review?(florian) → review+
Keywords: checkin-needed
Encountered this when applying the patch:

applying im-resource.patch
unable to find 'chat/content/imtooltip.css' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file chat/content/imtooltip.css.rej
unable to find 'chat/content/imtooltip.xml' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file chat/content/imtooltip.xml.rej
unable to find 'chat/content/jar.mn' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file chat/content/jar.mn.rej
unable to find 'chat/themes/imtooltip.css' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file chat/themes/imtooltip.css.rej
unable to find 'mail/base/content/messenger.xul' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file mail/base/content/messenger.xul.rej
unable to find 'mail/components/im/content/imconversation.xml' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file mail/components/im/content/imconversation.xml.rej
unable to find 'mail/components/im/themes/chat.css' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file mail/components/im/themes/chat.css.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh im-resource.patch
Flags: needinfo?(richard.marti)
This is a Thunderbird bug that applies to comm-central and not m-c.
Flags: needinfo?(richard.marti)
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/9f7c2f60e3ef312d4f57b42acba4b3b25e7b5a09
Remove <resources> from imconversation.xml and imtooltip.xml. r=florian
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 63.0
You need to log in before you can comment on or make changes to this bug.