1474091 - TEST-UNEXPECTED-FAIL | [snip]/message-header/test-message-header.js | test-message-header.js::test_a11y_attrs

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1298339 +++

This is happening more and more now but not always:
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1530962987/build/tests/mozmill/message-header/test-message-header.js | test-message-header.js::test_a11y_attrs

Fri, Jul 6, 2018, 02:19:12
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=a2edf68a0bf2caf2b024c66ab5af74d0d7b9e115&selectedJob=186803432

Sat, Jul 7, 2018, 12:58:41
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=a75878fe1f574a55f9e03ac27027f11e5fa336e3&selectedJob=186983717

https://taskcluster-artifacts.net/f_ttHcaFQPqDxFwuPGP7qQ/0/public/logs/live_backing.log says:
INFO -  SUMMARY-UNEXPECTED-FAIL | test-message-header.js | test-message-header.js::test_a11y_attrs
INFO -    EXCEPTION: headerAccessible is null
INFO -      at: test-message-header.js line 259
INFO -         verify_header_a11y test-message-header.js:259 1
INFO -         test_a11y_attrs test-message-header.js:302 3

Aceman, could you please have a look.

Comment 1

[Jorg K (CEST = GMT+2)]

Geoff, next time you feel like fixing a test failure with one line, this is now the top failing test.

Recent log:
https://taskcluster-artifacts.net/GQnFENnGQ5-37fuJaNVCSQ/0/public/logs/live_backing.log

INFO -  SUMMARY-UNEXPECTED-FAIL | test-message-header.js | test-message-header.js::test_a11y_attrs
INFO -    EXCEPTION: headerAccessible is null, can't access property "role" of it
INFO -      at: test-message-header.js line 259
INFO -         verify_header_a11y test-message-header.js:259 3
INFO -         test_a11y_attrs test-message-header.js:302 3

Comment 2

[:aceman]

Attachment: WIP

Here is my current WIP patch about what I have tried.

Comment 3

[Jorg K (CEST = GMT+2)]

Looks like Geoff gave this a repeated run and it's looking good:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=173433f969c978b91e11fdaf060005e7f9398bf7

Comment 4

[:aceman]

Attachment: 1474091.patch

Thanks, at least it does not hurt so let's try to land it and see if it fixes the problem permanently.

The main fix is the added
mc.waitFor(() => (headerAccessible = gAccService.getAccessibleFor(headerValueElement))

The rest is cleanup and removal of "eval".

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9008181 [details] [diff] [review]
1474091.patch

Review of attachment 9008181 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, to of the most notorious tests fixed within 48 hours. Is there a competition going on? If so, consider: https://mzl.la/2gS72WO

::: mail/test/mozmill/message-header/test-message-header.js
@@ +270,5 @@
> +                    "element not found for header " + aHeaderInfo.headerName);
> +
> +  let headerAccessible;
> +  mc.waitFor(() => (headerAccessible = gAccService.getAccessibleFor(headerValueElement)) != null,
> +    "didn't find accessible element for header '" + aHeaderInfo.headerName + "'");

This and the two below could be more legible using template literals, the stuff using backticks:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

@@ +275,5 @@
>  
> +  assert_equals(headerAccessible.role, aHeaderInfo.expectedRole,
> +    "role for " + aHeaderInfo.headerName + " was " +
> +    headerAccessible.role + "; should have been " +
> +    aHeaderInfo.expectedRole);

`role for ${aHeaderInfo.headerName} was ${headerAccessible.role}; should have been 
${aHeaderInfo.expectedRole}`

@@ +281,5 @@
> +  let expectedName = aHeaderInfo.expectedName(mc, headerValueElement);
> +  assert_equals(headerAccessible.name, expectedName,
> +    "headerAccessible.name for " + aHeaderInfo.headerName +
> +    " was '" + headerAccessible.name + "'; expected '" +
> +    expectedName + "'");

and here.

Comment 6

[:aceman]

Attachment: 1474091.patch v1.1

Thanks

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a4f58095ed04
fix test-message-header.js by waiting for accessible element for message header to appear. r=jorgk

Comment 8

[Jorg K (CEST = GMT+2)]

TB 63 beta:
https://hg.mozilla.org/releases/comm-beta/rev/afa20ac7246a