Closed
Bug 1474118
Opened 6 years ago
Closed 6 years ago
Remove unneeded quick-search code
Categories
(Thunderbird :: Search, enhancement)
Thunderbird
Search
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 63.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file)
|
3.11 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
During checking the removal of the <resources> from search.xml, I've found the code using the <resources> is no more used.
|
Assignee | |
Comment 1•6 years ago
|
||
I see no change with this patch. Please play a bit with QFB to be sure I haven't regressed something.
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8990522 [details] [diff] [review] quick-search-code-remove.patch DXR tells me that both quick-search-button and quick-search-clearbutton are unused, quick-search-button-image is used and I cannot say whether removal of the hunk for Mac causes any problem. The other platforms don't have it, so it's most likely OK. I also did a bit of testing and saw no problem.
Attachment #8990522 -
Flags: review?(jorgk) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
quick-search-button-image is only used inside the searchBarDropMarker binding which is loaded by the not used quick-search-button.
Keywords: checkin-needed
|
|
||
Comment 4•6 years ago
|
||
Thanks, I see it now.
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/fb4fd4704e5e Remove unneeded quick-search CSS code. r=jorgk
|
|
||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 63.0
You need to log in
before you can comment on or make changes to this bug.
Description
•