Closed Bug 1474123 Opened 6 years ago Closed 6 years ago

Remove <resources> from calendar

Categories

(Calendar :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Bug 1474069 will remove support for XBL <resources>, meaning that all XBL
stylesheets should become regular stylesheets, similarly to the dependencies of
bug 1470830.

In calendar there are 20 results: https://dxr.mozilla.org/comm-central/search?q=%3Cresources%3E+-path%3Aobj-x86+path%3Acalendar&redirect=false

because Lightning isn't working in TB I can't work on this.
It will be working soon, in fact, Geoff has a working version that passes Mozmill tests and that will land soon. Maybe he wants to take care of this bug.
Flags: needinfo?(geoff)
(In reply to Jorg K (GMT+2) from comment #1)
> It will be working soon, in fact, Geoff has a working version that passes
> Mozmill tests and that will land soon. Maybe he wants to take care of this
> bug.

A working version that passes *most* Mozmill tests. Hoping to have it reviewed and landed by the end of the week. (I know that's what I said last week, but I didn't anticipate problems with said Mozmill test.)
Depends on: 1472883
Flags: needinfo?(geoff)
Lightning is working again, so this bug can be worked on now. Bug 1474069 hasn't moved much.
Blocks: 1480039
Attached patch calendar-resources.patch — — Splinter Review
This patch removes all <resource>s. Please check, if I really catched all appearances of minimonth and datetimepicker to style them.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8999423 - Flags: review?(makemyday)
Comment on attachment 8999423 [details] [diff] [review]
calendar-resources.patch

Review of attachment 8999423 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - thank you for taking care of it.
Attachment #8999423 - Flags: review?(makemyday) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8c3e0bc05d5b
Remove <resources> from calendar. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.5
Depends on: 1487357
Depends on: 1515956
Depends on: 1499475
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: