Closed Bug 1474244 Opened 6 years ago Closed 6 years ago

ASRouter calls uninit on any pref change

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 63
Iteration:
63.2 - July 23
Tracking Status
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: andreio, Assigned: andreio)

References

Details

User Story

https://github.com/mozilla/activity-stream/compare/firefox-62b7...firefox-62b10

Attachments

(2 files, 1 obsolete file)

The check to disable ASRouter will almost always be true [0] when we have enabled it manually because the check for isOnboardingExperimentEnabled will always return true.
This affects the work in bug 1462114, I'll try to bundle the two together.

[0] https://github.com/mozilla/activity-stream/blob/783442c07e7f6f9381a0d1abd47c187f9cc3d08a/lib/ASRouterFeed.jsm#L42
Assignee: nobody → andrei.br92
Iteration: --- → 63.2 - July 23
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/fea35af556db03c5c64d1eed20b1b24b4cdb3d45
Fix Bug 1474244 - Prevent ASRouter uninit from being called for unrelated pref changes
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
User Story: (updated)
Depends on: 1472209
Blocks: 1474338
Comment on attachment 8991410 [details] [diff] [review]
Bug-1474244-Prevent-ASRouter-uninit-from-being-calle.patch

Should this bug be tracking 62 and this patch attachment 8991410 [details] [diff] [review] request approval? Is this blocked on anything?
Flags: needinfo?(andrei.br92)
Comment on attachment 8991410 [details] [diff] [review]
Bug-1474244-Prevent-ASRouter-uninit-from-being-calle.patch

Approval Request Comment
[Feature/Bug causing the regression]: Activity Stream Router experiment
[User impact if declined]: Users can be unenrolled from the experiment 
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No 
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small patch
[String changes made/needed]: n/a
Flags: needinfo?(andrei.br92)
Attachment #8991410 - Flags: approval-mozilla-beta?
Marking this as affected since we intent to run an onboarding overlay experiment (bug 1473580
)  in 62 beta/release, which depends on this activity stream router code.
Comment on attachment 8991410 [details] [diff] [review]
Bug-1474244-Prevent-ASRouter-uninit-from-being-calle.patch

Let's uplift for beta 10 so that users will not be accidentally unenrolled from the study.
Attachment #8991410 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 1471514
User Story: (updated)
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: