1474300 - Update webrender to e600bfe68efac6416ce2e8091d7344744771f6db

Status: RESOLVED INCOMPLETE

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1473284 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 0e9563688e575cd662570f54bc9d6f849040dbf8

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c1d820c4f0d9393dfbc0e7c03941867e8531ff3

Green

WR @ 7cfa6e34246b47cc1adafa8cba8477c7b8dbe0e4

https://treeherder.mozilla.org/#/jobs?repo=try&revision=82f4a9c9ae1c0eee36cc6dc16eb293c47d91a47b

Very orange, I need to apply the gecko side of servo/webrender#2871.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ 7cfa6e34246b47cc1adafa8cba8477c7b8dbe0e4 with gecko patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03057cd9715efa2b601d981c7c9cf03cb7e336d2

Green so far

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ 7cfa6e34246b47cc1adafa8cba8477c7b8dbe0e4

https://treeherder.mozilla.org/#/jobs?repo=try&revision=753464c3a6a4cf2a9aefcaee3608122a4baf5767

Green

WR @ 5f0967e21bda845cd6caff6b81a995b3b0e93a86

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c162b7f8fa05d6b535e9fca5aa54478503846560

Green (so far)

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 5f0967e21bda845cd6caff6b81a995b3b0e93a86

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3be1c8ed7be67587d7828973a05aad74fce5ee2a

Green

WR @ a30fd2286f424e528e3bde502d1a11ed5ef7ec31

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a610998a90c0e81ac74e1e4eded1bf2228aa6d1

Green

WR @ 091e9c53acd71fea20da18ea3a3d5eec7ac6c7d5

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5939d4c46ed105821a6a6a8d4b5771259e821b3

Green

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ e600bfe68efac6416ce2e8091d7344744771f6db

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eff7ef875872f29cd33d7e82dfeb241aa19d9dfa

Green so far

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1474300 - Update webrender to commit e600bfe68efac6416ce2e8091d7344744771f6db.

Review commit: https://reviewboard.mozilla.org/r/256556/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256556/

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1474300 - Update Cargo lockfiles and re-vendor rust dependencies.

Review commit: https://reviewboard.mozilla.org/r/256558/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256558/

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1474300 - Update for API changes in WR PR 2871.

This change has WrClipId contain the ClipId type (except for clip
chains, which are handled separately) in the least significant bit of
the size_t. On 32-bit systems this limits the number of clip and spatial
nodes to 2,147,483,648 which is likely more than what WebRender can
handle.

Review commit: https://reviewboard.mozilla.org/r/256560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256560/

Comment 9

[Aria Beingessner [:Gankra]]

Comment on attachment 8991633 [details]
Bug 1474300 - Update webrender to commit e600bfe68efac6416ce2e8091d7344744771f6db.

https://reviewboard.mozilla.org/r/256556/#review263704

Comment 10

[Aria Beingessner [:Gankra]]

Comment on attachment 8991634 [details]
Bug 1474300 - Update Cargo lockfiles and re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/256558/#review263706

Comment 11

[Aria Beingessner [:Gankra]]

Comment on attachment 8991635 [details]
Bug 1474300 - Update for API changes in WR PR 2871.

https://reviewboard.mozilla.org/r/256560/#review263712

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/376e702ed3ea
Update webrender to commit e600bfe68efac6416ce2e8091d7344744771f6db. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/a65429a135c7
Update Cargo lockfiles and re-vendor rust dependencies. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/f7659b60b7b0
Update for API changes in WR PR 2871. r=Gankro

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/376e702ed3ea
https://hg.mozilla.org/mozilla-central/rev/a65429a135c7
https://hg.mozilla.org/mozilla-central/rev/f7659b60b7b0

Comment 14

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/f97ba5c963ff
Backed out 3 changesets on request by kats for introducing a crasher a=backout

Comment 15

[Andreea Pavel [:apavel]]

Backed out on request by :kats

Backout: https://hg.mozilla.org/mozilla-central/rev/f97ba5c963ffbda5cb0b793047e581ae55d20530

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Thanks! Will wait for a fix by mrobinson before relanding this.

Comment 17

[Kartikaya Gupta (email:[e-mail])]

I'm going to close this bug. Bug 1475252 will include these changes plus mrobinson's fix plus whatever else landed in the meantime.