1474306 - Fix typo in the extension optionsType handler

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Igor Oliveira]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180703120607

Steps to reproduce:

XPIInstall.jsm has a typo in the optionsType handler:

    if (addon.optionsType &&
        addon.optionsType != AddonManager.OPTIONS_INLINE_BROWSER &&
        addon.optionsType != AddonManager.OPTIONS_TYPE_TAB) {
      throw new Error("Install manifest specifies unknown optionsType: " + addon.optionsType);
}

AddonManager.OPTIONS_INLINE_BROWSER doesn't exist, it should be AddonManager.OPTIONS_TYPE_INLINE_BROWSER

Comment 1

[Igor Oliveira]

Attachment: 0001-Bug-1474306-Fix-typo-in-the-extension-optionsType-ha.patch

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I don't think I can review toolkit changes.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8990713 [details] [diff] [review]
0001-Bug-1474306-Fix-typo-in-the-extension-optionsType-ha.patch

Review of attachment 8990713 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b60d9901c566
Fix typo in the extension optionsType handler. r=Mossop

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b60d9901c566