1474364 - Flex badge in inspector doesn't toggle off, on second click

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

STR:
0. enable about:config prefs:
  devtools.inspector.flexboxHighlighter.enabled
  devtools.flexboxinspector.enabled

1. Visit attached testcase and open DevTools inspector.

2. Try clicking the "flex" and "grid" badges in the inspector -- clicking each badge several times in a row.

ACTUAL RESULTS:
The grid badge seems to toggle on & off correctly when you click it multiple times, but the flex badge does not -- it just stays selected/highlighted after it's been clicked, even on repeat clicks.

EXPECTED RESULTS:
Flex badge should toggle off (highlighting/outline should disappear) on the second click.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1474364 - Clear the stored flexbox highlighter shown before emitting the event.

Review commit: https://reviewboard.mozilla.org/r/256894/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256894/

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8992003 [details]
Bug 1474364 - Clear the stored flexbox highlighter shown before emitting the event.

https://reviewboard.mozilla.org/r/256894/#review263970

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40d4a3f314f8
Clear the stored flexbox highlighter shown before emitting the event. r=pbro

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/40d4a3f314f8