1474385 - Debugger: Code cleanup in resumption value handling

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jason Orendorff [:jorendorff]]

In bug 1471954, I want to make a change that affects some very messy code. Might as well clean that up a bit first.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Part 1: Rename and comment a Debugger method involved in error handling

We will in fact delete this method later in the stack, but to understand those
coming patches, it helps to understand what's going on here.

Comment 2

[Jason Orendorff [:jorendorff]]

The main upshot of this stack is that the code gets a bit shorter, comments are marginally better, and instead of two copies of the main exit path, when returning from the debugger to the debuggee, there is now just one. This last item is what bug 1471954 wants.

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: Part 2: Code motion. Move resumption value code above uncaughtExceptionHook code because a later patch calls ParseResumptionValue from the uncaughtExceptionHook code

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: Part 3: Common up the usual exit path from the debugger back to debuggee code

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: Part 4: Merge ParseResumptionValueAsObject into its sole caller

Comment 6

[Jim Blandy :jimb]

Comment on attachment 8990783 [details] [diff] [review]
Part 3: Common up the usual exit path from the debugger back to debuggee code

Review of attachment 8990783 [details] [diff] [review]:
-----------------------------------------------------------------

This is great: after drawing my diagrams of the Debugger handler result processing, I took some notes about two easy cleanups I wanted to do, and you've done one of them!

Comment 7

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4fa3219f7142
https://hg.mozilla.org/integration/mozilla-inbound/rev/4de401c4d69c
https://hg.mozilla.org/integration/mozilla-inbound/rev/45748228a3a1
https://hg.mozilla.org/integration/mozilla-inbound/rev/2dca476565cb

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/4fa3219f7142
https://hg.mozilla.org/mozilla-central/rev/4de401c4d69c
https://hg.mozilla.org/mozilla-central/rev/45748228a3a1
https://hg.mozilla.org/mozilla-central/rev/2dca476565cb