Closed Bug 1474385 Opened 3 years ago Closed 3 years ago

Debugger: Code cleanup in resumption value handling

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

Details

Attachments

(4 files)

In bug 1471954, I want to make a change that affects some very messy code. Might as well clean that up a bit first.
We will in fact delete this method later in the stack, but to understand those
coming patches, it helps to understand what's going on here.
Attachment #8990781 - Flags: review?(jimb)
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
The main upshot of this stack is that the code gets a bit shorter, comments are marginally better, and instead of two copies of the main exit path, when returning from the debugger to the debuggee, there is now just one. This last item is what bug 1471954 wants.
Attachment #8990781 - Flags: review?(jimb) → review+
Attachment #8990782 - Flags: review?(jimb) → review+
Comment on attachment 8990783 [details] [diff] [review]
Part 3: Common up the usual exit path from the debugger back to debuggee code

Review of attachment 8990783 [details] [diff] [review]:
-----------------------------------------------------------------

This is great: after drawing my diagrams of the Debugger handler result processing, I took some notes about two easy cleanups I wanted to do, and you've done one of them!
Attachment #8990783 - Flags: review?(jimb) → review+
Attachment #8990789 - Flags: review?(jimb) → review+
Blocks: 1475417
You need to log in before you can comment on or make changes to this bug.