1474405 - Replace firefox-dev in alert_emails of 9 FX_SANITIZE histograms

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, enhancement)

Description

[Chris H-C :chutten]

Hello,

Upon reviewing the list of Telemetry histograms we found nine FX_SANITIZE metrics that us the firefox-dev@ mailing list in their alert_emails field.

This means in event of a Telemetry Alert being fired, it will be sent to the entirety of firefox-dev.

The alert_emails field has been shown to be most useful when it has an individual or a small team's address in it (or both!) as it both ensures that any such Alerts are received only by individuals who likely understand what the change means (and maybe even why it happened) and acts as a useful lookup in case someone later has a question about the probe and needs to ask questions of someone about it.

Is there someone who is willing to take on such a role for the following probes:

FX_SANITIZE_TOTAL
FX_SANITIZE_CACHE
FX_SANITIZE_COOKIES_2
FX_SANITIZE_HISTORY
FX_SANITIZE_FORM_DATA
FX_SANITIZE_DOWNLOADS
FX_SANITIZE_SESSIONS
FX_SANITIZE_SITESETTINGS
FX_SANITIZE_OPENWINDOWS

If not, should we remove the probes?

[1]: https://wiki.mozilla.org/Firefox/Data_Collection

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I'm available, if we can take 2 owners I suppose johann could also be added (if he agrees)

Comment 2

[Chris H-C :chutten]

alert_emails is an array with... I'm theorizing a limit of size_t items? So, two? We can probably support two :D

If you can get the patch around to me within the next eight hours or so I'll be happy to review it for you. Otherwise, :janerik, :Dexter, or :gfritzsche will be happy to take a module perspective on the patch.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1474405 - Fix FX_SANITIZE histogram owners. r=chutten,johannh

Histogram owners should be actual owners

Comment 4

[Phabricator Automation]

Comment on attachment 8991017 [details]
Bug 1474405 - Fix FX_SANITIZE histogram owners. r=chutten,johannh

Johann Hofmann [:johannh] has approved the revision.

https://phabricator.services.mozilla.com/D2051

Comment 5

[Phabricator Automation]

Comment on attachment 8991017 [details]
Bug 1474405 - Fix FX_SANITIZE histogram owners. r=chutten,johannh

Chris H-C :chutten has approved the revision.

https://phabricator.services.mozilla.com/D2051

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7872b6bba62
Fix FX_SANITIZE histogram owners. r=johannh,chutten

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e7872b6bba62