Restore spinbuttons and number boxes in SeaMonkey.

RESOLVED FIXED in Future

Status

enhancement
RESOLVED FIXED
Last year
11 months ago

People

(Reporter: frg, Assigned: frg)

Tracking

(Blocks 1 bug)

SeaMonkey 2.57 Branch
Future
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.53 unaffected, seamonkey2.57esr affected, seamonkey2.60 wontfix)

Details

Attachments

(3 attachments, 3 obsolete attachments)

Spinboxes in Preferences and elsewhere are currently broken. Thunderbird restored them in Bug 1453233 and a few other bugs. We just need to include the correct bindings adn add the missing css.

+++ This bug was initially created as a clone of Bug #1453233 +++

We removed the spinbuttons from number fields (proxy port numbers, cache size, various wait intervals) in bug 1453233 because since bug 1437302 they don't work any more.

History: Removed from M-C in bug 1429573 on 10th Feb and restored in TB in March in bug 1446329.
Posted patch 1474490-spinbox.patch (obsolete) — Splinter Review
Works but I need to split the mail part off for a separate review and also check it a bit more.
Posted patch 1474490-spinbox.patch (obsolete) — Splinter Review
And this one does actually compile. Sorry.
Attachment #8990882 - Attachment is obsolete: true
Note that <resources> in xbl are gone so on trunk you need to @import the css files (see https://hg.mozilla.org/comm-central/rev/5205ff465bd3 for how Paenglab did it).
suite part for comm-central and comm-esr60. As stefanh pointed out this needs a followup bug for comm-central to cover bug 1474171. But this needs to be more global and must cover the other bindings too so I just added this to bug 1452448 for later.
Attachment #8990994 - Attachment is obsolete: true
Attachment #9007509 - Flags: review?(iann_bugzilla)
Attachment #9007509 - Flags: approval-comm-esr60?
Joerg,
the spinbox binding needs to be preprocessed and take suite into account. Could you give this part a blessing for comm-esr60 only if ok. IanN can set approval later.
Attachment #9007510 - Flags: review?(jorgk)
Attachment #9007510 - Flags: approval-comm-esr60?
Comment on attachment 9007510 [details] [diff] [review]
1474490-spinbox-mail-esr60.patch

Review of attachment 9007510 [details] [diff] [review]:
-----------------------------------------------------------------

::: common/bindings/numberbox.xml
@@ +21,1 @@
>      </resources>

Would you mind duplicating this tag and moving it into if+else. This looks terrible ;-(
Attachment #9007510 - Flags: review?(jorgk) → review+
Thanks and changed. r+ from jorgk carried forward. a+ assumed.
Attachment #9007510 - Attachment is obsolete: true
Attachment #9007510 - Flags: approval-comm-esr60?
Attachment #9007514 - Flags: review+
Attachment #9007514 - Flags: approval-comm-esr60?
I cannot a+ SM bugs :-( - So you'll have to organise that yourself.
Comment on attachment 9007514 [details] [diff] [review]
1474490-spinbox-mail-esr60.patch

a=me
Attachment #9007514 - Flags: approval-comm-esr60? → approval-comm-esr60+
Comment on attachment 9007509 [details] [diff] [review]
1474490-spinbox.patch

>+++ b/suite/base/content/communicator.css

>+/******* numberboxe *******/
Nit: An extra e, should be numberbox
>+textbox[type="number"] {
>+  -moz-binding: url('chrome://communicator/content/bindings/numberbox.xml#numberbox');
Nit: Use " instead of ' like the rest of the file

Is it worth copying the numberbox.css and spinboxes.css from TB and adapting rather than creating as new files?

r/a=me with the nits fixed but easy either way with how the css files are created.
Flags: needinfo?(frgrahl)
Attachment #9007509 - Flags: review?(iann_bugzilla)
Attachment #9007509 - Flags: review+
Attachment #9007509 - Flags: approval-comm-esr60?
Attachment #9007509 - Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b722826d2444
Restore spinbox and number boxes in SeaMonkey. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
nits fixed in push. Per irc we agreed to just create the css files and not copy them.
Flags: needinfo?(frgrahl)
Target Milestone: --- → Future
nit fixed esr60 version
You need to log in before you can comment on or make changes to this bug.