Closed
Bug 1474512
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 11877 - [css-text] Avoid mid-word breaking if there are previous opportunities
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 11877 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/11877 Details from upstream follow. Javier Fernandez <jfernandez@igalia.com> wrote: > [css-text] Avoid mid-word breaking if there are previous opportunities > > Leading white-spaces are indeed breaking opportunities that should > prevent, if there are no other css properties forcing it, breaking text > in the middle of a word. > > We are doing so if the leading white-space sequence is longer than 1 > character, but when we have a single leading white-space, we are missing > that breaking opportunity and we may lead to cases, like the one > described in the bug, where the word is broken to avoid an overflow, > honoring the overflow-wrap property. > > This change tries to solve the issue by preventing to execute the last > part of the BreakingContext::HandleText logic, where we try to rewind > to the previous mid-word breaking opportunity. The idea is to detect > white-space breaking opportunities in the PrepareForNextCharacter > function that indicates that it doesn't make sense to break the word. > > Bug: 854624 > Change-Id: I49ec8282e899a32990662c104b48cab04057b909 > > Reviewed-on: https://chromium-review.googlesource.com/1130515 > WPT-Export-Revision: b0041b360f757f805ccae327538a485378b008ff
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed05aff6fd27c4fab8624ca87b9d3b8eebd45109
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=13067d8b78918b8b10d612bd6f42e5cfb9d56e2e
Assignee | ||
Comment 3•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=16107f38302c6dc3e0bb5fa6b5a54f0002dd5717
Assignee | ||
Comment 4•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=223ab5351dcc03a6b94463d457ceba05bf5e96f9
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Comment 5•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2b03a24e8b3fbe3e55f4b689330319fbb3ab608
Assignee | ||
Comment 6•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=99bd533e0ef3d52b543d0f14197ada19edc9dd7b
Assignee | ||
Comment 7•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d15e7812557fd8eb399c8881ba17b67a31c6bc7
Assignee | ||
Comment 8•6 years ago
|
||
Ran 3 tests FAIL : 3 New tests that have failures or other problems: /css/css-text/overflow-wrap/overflow-wrap-break-word-004.html: FAIL /css/css-text/word-break/word-break-break-all-010.html: FAIL /css/css-text/word-break/word-break-break-all-011.html: FAIL
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/b72657957d1a [wpt PR 11877] - [css-text] A leading white-space should break before handling overflow, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/bed363efc11e [wpt PR 11877] - Update wpt metadata, a=testonly
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b72657957d1a https://hg.mozilla.org/mozilla-central/rev/bed363efc11e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•