1474553 - [br] freelang search failed, should be changed to https

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Tian, Sheng]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180704003137

Steps to reproduce:

Fresh install of Firefox
Search something via freelang


Actual results:

Firefox try to search via `POST http://www.freelang.com/enligne/breton.php?lg=fr`and get 302 redirect to `GET https://www.freelang.com/enligne/breton.php?lg=fr`; as a result, no search performed.



Expected results:

Perform a searching

(Change the URL to https should work.)

Comment 1

[Francesco Lodolo [:flod]]

- Switched URL to https, fixed params (no need for a separate searchform)
- Added 32px icon

Available for testing here: https://l10n.mozilla-community.org/~flod/testsp/

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Bug 1474553 - [br] Update Freelang searchplugin to https, update icon

Review commit: https://reviewboard.mozilla.org/r/257140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257140/

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 8992263 [details]
Bug 1474553 - [br] Update Freelang searchplugin to https, update icon

https://reviewboard.mozilla.org/r/257140/#review264030

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48135d258983
[br] Update Freelang searchplugin to https, update icon r=mkaply

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/48135d258983

Comment 6

[Francesco Lodolo [:flod]]

Verified in 63.0a1 (2018-07-17) (64-bit)

Comment 7

[Francesco Lodolo [:flod]]

Comment on attachment 8992263 [details]
Bug 1474553 - [br] Update Freelang searchplugin to https, update icon

Approval Request Comment

[Feature/Bug causing the regression]: change on the website (switch to SSL) broke the existing searchplugin

[User impact if declined]: search on Freelang is broken 

[Is this code covered by automated tests?]: No

[Has the fix been verified in Nightly?]: Yes

[Needs manual test from QE? If yes, steps to reproduce]: No

[List of other uplifts needed for the feature/fix]: None

[Is the change risky?]: No

[Why is the change risky/not risky?]: Secondary (non default) searchplugin, only affecting Breton (br) builds

[String changes made/needed]: None

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8992263 [details]
Bug 1474553 - [br] Update Freelang searchplugin to https, update icon

Fix should be limited to this specific plugin, ok to uplift to beta.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9573e5a35f1c