Closed Bug 1474643 Opened Last year Closed Last year

fix isTopLevel

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

57 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: tarek, Assigned: florian)

Details

Attachments

(1 file)

follow up on bug 1474253

s/
isTopLevel = top->IsTopLevelWindow();
/
isTopLevel = outer->IsTopLevelWindow();
Priority: -- → P3
Attached patch FixSplinter Review
Attachment #8991233 - Flags: review?(amarchesini)
Assignee: tarek → florian
Status: NEW → ASSIGNED
r- this needs a test
Comment on attachment 8991233 [details] [diff] [review]
Fix

This could do with a test indeed.
Attachment #8991233 - Flags: review?(amarchesini)
Tarek told me he's already working on this and writing a test, I didn't mean to steal his bug; sorry for the confusion.
Assignee: florian → tarek
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70d06bb319fe
make ReportPerformanceInfo's isTopLevel report the correct information, r=baku.
(In reply to Florian Quèze [:florian] from comment #4)
> Tarek told me he's already working on this and writing a test, I didn't mean
> to steal his bug; sorry for the confusion.

Actually, Tarek told me his work in progress patch is growing in scope and would be better in another bug, so I went ahead and pushed the patch.
Assignee: tarek → florian
https://hg.mozilla.org/mozilla-central/rev/70d06bb319fe
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.