Closed Bug 1474646 Opened Last year Closed Last year

Bump euclid to 0.18 for webrender

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: boris, Assigned: boris)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files, 1 obsolete file)

44 bytes, text/x-github-pull-request
Details | Review
44 bytes, text/x-github-pull-request
Details | Review
Attached file plane-split PR #13
Bug 1467277 bumped euclid to 0.18 for style. However, we did't bump it for gfx in that bug. Let's do this here. Besides, euclid had been bumped in plane-split, so it's time to update euclid everywhere in Gecko.
Actually I don't know what this patch is doing at all.
Sorry. That patch is just a notification for the update of the API, Polygon::from_transformed_rect() in gfx/webrender. I didn't fix this bug for now.

[1] https://searchfox.org/mozilla-central/rev/28daa2806c89684b3dfa4f0b551db1d099dda7c2/gfx/webrender/src/batch.rs#1717
Ah, I see. So yeah, you should submit a PR against the webrender github repo to bump the version of plane-split/euclid there, and then when we sync it to m-c this will get fixed.
Got it. I will check it. Thanks for the help, kats :)
Assignee: nobody → boris.chiou
Attached file webrender, PR #2882 (obsolete) —
This PR is dependent on https://github.com/pcwalton/pathfinder/pull/89
Priority: -- → P1
Whiteboard: [gfx-noted]
Attached file webrender, PR #2904
Attachment #8991377 - Attachment is obsolete: true
Webrender PR #2904 was merged last week, so let's close this bug.
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.