1474646 - Bump euclid to 0.18 for webrender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Boris Chiou [:boris]]

Attachment: plane-split PR #13

Bug 1467277 bumped euclid to 0.18 for style. However, we did't bump it for gfx in that bug. Let's do this here. Besides, euclid had been bumped in plane-split, so it's time to update euclid everywhere in Gecko.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This looks like it should be a PR against https://github.com/servo/webrender

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Actually I don't know what this patch is doing at all.

Comment 3

[Boris Chiou [:boris]]

Sorry. That patch is just a notification for the update of the API, Polygon::from_transformed_rect() in gfx/webrender. I didn't fix this bug for now.

[1] https://searchfox.org/mozilla-central/rev/28daa2806c89684b3dfa4f0b551db1d099dda7c2/gfx/webrender/src/batch.rs#1717

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Ah, I see. So yeah, you should submit a PR against the webrender github repo to bump the version of plane-split/euclid there, and then when we sync it to m-c this will get fixed.

Comment 5

[Boris Chiou [:boris]]

Got it. I will check it. Thanks for the help, kats :)

Comment 6

[Boris Chiou [:boris]]

Attachment: webrender, PR #2882

This PR is dependent on https://github.com/pcwalton/pathfinder/pull/89

Comment 7

[Boris Chiou [:boris]]

Attachment: webrender, PR #2904

Comment 8

[Boris Chiou [:boris]]

Webrender PR #2904 was merged last week, so let's close this bug.