Closed Bug 1474653 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 11887 - [css-layout-api] Don't use LayoutNG for custom layout children.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 11887 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11887
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  [css-layout-api] Don't use LayoutNG for custom layout children.
>  
>  Custom layout children may not establish new formatting contexts, and
>  since the custom container itself is laid out by the legacy engine, we
>  need to force its children to be laid out by legacy as well.
>  
>  Added a margin collapsing test that used to fail in NG because of this.
>  
>  Change-Id: Id320f60fb76b0ed6563fb2b88f6936ac37efc1fd
>  Reviewed-on: https://chromium-review.googlesource.com/1131179
>  WPT-Export-Revision: 6266422228d59087813cd0006ce825999f260cc0
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests
FAIL   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fef47b7fc132
[wpt PR 11887] - [css-layout-api] Don't use LayoutNG for custom layout children., a=testonly
https://hg.mozilla.org/mozilla-central/rev/fef47b7fc132
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.