1474682 - Submit for review and merge unpublished terraform changes

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement)

Description

[Jake Watkins [:dividehex]]

/cc fubar, jlund and sylvestre

Hi Rok,

I think you might have unpublished changes to the build cloud tools terraform configs that are blocking this PR:  https://github.com/mozilla-releng/build-cloud-tools/pull/344

Therefore, I can't merge and apply the PR without destroying the uncommited/unpublished aws resources you may have setup outside of the master branch.

Can you please publish this code for review so it can be merged and we can unblock this PR.

Thanks,
Jake

<snippet>

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:

    destroy

Terraform will perform the following actions:

    aws_route53_record.heroku-mapper-cname-prod

    aws_route53_record.heroku-tokens-cname-prod

    aws_route53_record.heroku-tokens-cname-stage

    aws_route53_record.heroku-tokens-cname-test

Plan: 0 to add, 0 to change, 4 to destroy.

Comment 1

[Jake Watkins [:dividehex]]

If this becomes urgent and we need to move forward without the missing config resources, it is possible to remove the 4 resources from the terraform state file while leaving them intact in aws.  This would cause terraform to "forget" about the records and not attempt to destroy them.  In order to pull them back into the state file so that terraform can manage them again after the fact, they would either need to be destroyed (via the aws console) or imported back into the state file with terraform import option.  Either way the missing resources would need to be defined in the config and merged to master.

Comment 2

[Rok Garbas [:garbas]]

:dividehex

looks i forgot to push last week since i was in a hurry to finish relengapi migration. i will make sure everything is pushed so we can merge https://github.com/mozilla-releng/build-cloud-tools/pull/344

Comment 3

[Rok Garbas [:garbas]]

This was fixed in https://github.com/mozilla-releng/build-cloud-tools/pull/349