147469 - nsAppShellService::Initialize violates contract when it calls mAppShell->Create(0, nsnull)

Status: RESOLVED INVALID

(Core Graveyard :: Cmd-line Features, defect)

Description

[Jon Smirl]

In nsAppShellService the AppShell params are hardcoded to null. 

-  rv = mAppShell->Create(0, nsnull);
+  int argc;
+  char ** argv;
+  aCmdLineService->GetArgc(&argc);
+  aCmdLineService->GetArgv(&argv);
+  rv = mAppShell->Create(&argc, argv);
   if (NS_FAILED(rv))
     goto done;

From nsIAppShell.idl

 /**
  * Creates an application shell
  */ 
  void Create(inout int argc, inout string argv);

A better fix might be to move the code that initializes   rv = cmdLineArgs-
>Initialize(argc, argv); out of main1() and into nsAppShellService::Initialize
();

Comment 1

[Jon Smirl]

Attachment: Quick fix for hard coded nulls

Comment 2

[timeless]

at first i was going to say this wasn't a big deal
because http://lxr.mozilla.org/seamonkey/ident?i=GetArgc shows the relevant 
bits are called eventually.

however, the contract says inout, so that we pass 0 is a contract violation.

Comment 3

[Brendan Eich [:brendan]]

Obsolete code? If so, please close.

/be

Comment 4

[Benjamin Smedberg]

Yup, dead code.