Closed
Bug 1474716
Opened 6 years ago
Closed 6 years ago
An https PDF opened in a new tab is called as "Not Secure", respectively the padlock icon is missing
Categories
(Firefox :: Site Identity, defect, P3)
Tracking
()
RESOLVED
FIXED
Firefox 64
People
(Reporter: jan, Assigned: keeler)
References
()
Details
(Keywords: nightly-community, regression)
Attachments
(1 file)
42.75 KB,
image/png
|
Details |
1. Open https://www.natlawreview.com/article/german-court-issues-first-gdpr-ruling
2. First sentence: Right click on "first decision" > Open in new tab.
3. Switch to the second tab. If you don't see a padlock: That's the bug.
Screenshot:
mozregression --launch 2018-07-10 --pref security.insecure_connection_icon.enabled:true security.insecure_connection_text.enabled:true -a 'https://www.natlawreview.com/article/german-court-issues-first-gdpr-ruling'
It's seems to be rarely(?) possible to see a green padlock if you try a second time (on an existing connection with a cached pdf?) and wait a bit before switching tabs, but the default is a missing padlock.
This seems to be a longstanding bug:
mozregression --good 2014-09-01 --bad 2015-01-01 -a 'https://www.natlawreview.com/article/german-court-issues-first-gdpr-ruling'
> 5:58.40 INFO: Last good revision: 62990ec7ad78 (2014-11-05)
> 5:58.40 INFO: First bad revision: 2114ef80f6ae (2014-11-06)
> 5:58.40 INFO: Pushlog:
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=62990ec7ad78&tochange=2114ef80f6ae
Reporter | ||
Updated•6 years ago
|
Summary: A https PDF opened in a new tab is called as "Not Secure", respectively the padlock icon is missing → An https PDF opened in a new tab is called as "Not Secure", respectively the padlock icon is missing
Comment 1•6 years ago
|
||
I can reproduce this intermittently as well (first attempt I got the padlock, second time I didn't). Nothing obvious in the browser console. Possibly related to bug 971432?
Flags: needinfo?(ckerschb)
Comment 2•6 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #1)
> I can reproduce this intermittently as well (first attempt I got the
> padlock, second time I didn't). Nothing obvious in the browser console.
> Possibly related to bug 971432?
So, I can reproduce the issue as well (first time no green padlock, second time there was one). Unfortunately I don't have the cycles to debug this at the moment. However, stepping through nsMixedContentBlocker::ShouldLoad() for the various calls might shed some light on the underlying problem.
Flags: needinfo?(ckerschb)
Updated•6 years ago
|
Priority: -- → P3
Comment 3•6 years ago
|
||
Too late to fix in 63. We could still take a patch for 65 and potentially for 64.
Assignee | ||
Comment 5•6 years ago
|
||
I can't seem to reproduce this any longer - maybe the changes in bug 832834 or a follow-up fixed it?
Flags: needinfo?(jan)
Reporter | ||
Comment 6•6 years ago
|
||
Yes, thank you! :)
mozregression --find-fix --bad 2018-07-10 --good 2018-10-13 --pref security.insecure_connection_icon.enabled:true security.insecure_connection_text.enabled:true -a 'https://www.natlawreview.com/article/german-court-issues-first-gdpr-ruling'
> 17:16.74 INFO: First good revision: 2f4adf14e6231a1668558dd78ecbe56a421591b6
> 17:16.74 INFO: Last bad revision: 7056aff16fb8124f1d6043538b9947017c4623e4
> 17:16.74 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7056aff16fb8124f1d6043538b9947017c4623e4&tochange=2f4adf14e6231a1668558dd78ecbe56a421591b6
> 2f4adf14e623 Dana Keeler — bug 832834 - reimplement nsSecureBrowserUIImpl r=franziskus,Felipe
Status: NEW → RESOLVED
Closed: 6 years ago
Depends on: 832834
Flags: needinfo?(jan)
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•6 years ago
|
Updated•6 years ago
|
Assignee: nobody → dkeeler
Comment 7•6 years ago
|
||
I can reproduce this issue in Nightly 63.0a1 (2018-07-10) (64-bit) on Linux x86_64 (Arch)
I can verify that this is fixed in latest beta 64.0b12
Build ID 20181122182000
User Agent Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0
QA Whiteboard: [testday-20181123]
You need to log in
before you can comment on or make changes to this bug.
Description
•