Closed Bug 1474766 Opened Last year Closed Last year

Remove some unnecessary templating from KeyframeEffect.cpp

Categories

(Core :: DOM: Animation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: birtles, Assigned: birtles)

Details

Attachments

(2 files)

As of bug 1456394 there is only one type of KeyframeEffect but we still use the KeyframeEffectType template parameter in KeyframeEffect.cpp. We should drop that and simplify things a little.
Comment on attachment 8991170 [details]
Bug 1474766 - Drop KeyframeEffectType template arg;

https://reviewboard.mozilla.org/r/256138/#review263022
Attachment #8991170 - Flags: review?(hikezoe) → review+
Comment on attachment 8991171 [details]
Bug 1474766 - Merge the three-argument form of KeyframeEffect::Constructor and ConstructKeyframeEffect;

https://reviewboard.mozilla.org/r/256140/#review263024

Nice.  I was going to leave a comment about this in the previous patch. :)
Attachment #8991171 - Flags: review?(hikezoe) → review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32e9955678b3
Drop KeyframeEffectType template arg; r=hiro
https://hg.mozilla.org/integration/autoland/rev/411b0d0d67c5
Merge the three-argument form of KeyframeEffect::Constructor and ConstructKeyframeEffect; r=hiro
https://hg.mozilla.org/mozilla-central/rev/32e9955678b3
https://hg.mozilla.org/mozilla-central/rev/411b0d0d67c5
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.