1474807 - Firefox with many tabs open will hang when enabling Snap Links Plus extension

Status: RESOLVED MOVED

(WebExtensions :: Developer Outreach, defect, P5)

Description

[get_logan]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180709172241

Steps to reproduce:

Open many tabs. Then install or enable (must be disabled beforehand) the Snap Links Plus extension.


Actual results:

Firefox will become unresponsive and hang for some time depending on how many tabs are open. This can be several minutes where the user is unable to interact with the browser.

Here is a performance profile I recorded using a new profile in nightly 63.0a1 (2018-07-10):
https://perfht.ml/2KNx0fi

For that recording I opened 42 tabs and then enabled Snap Links Plus.


Expected results:

Firefox should have continued to respond to user interaction at a reasonable pace.

Comment 1

[get_logan]

Affects Firefox stable 61.0.1, beta 62.0b7 and latest nightly 63.0a1 (2018-07-10).

Comment 2

[Gyula Palko[:gpalko]]

Hello,

  I can reproduce the issue on current Fx release 61.0.1 and also on latest Nightly(20180715220110) and Beta(62.0b8)

Thanks for reporting!

Comment 3

[David Durst [:ddurst]]

Apologies for the delay, this fell into a triage gap. Is this still reproducible?

Comment 4

[Caitlin Neiman [:caitmuenster]]

Filed issue at https://github.com/cpriest/SnapLinksPlus/issues/280 on May 24, 2019.

Comment 5

[Clint Priest]

Didn't realize this was also a bug here, was about to file a bug and saw this.

I have largely resolved the issue, the vast majority of it was from a library that a contributor added which was just not doing things properly. (In addition, I was not 'delaying initialization' until the last possible moment either in a few places.

I'm hoping to push v3.1.7 in the next couple of days that has that library re-written and the delayed initialization all done correctly (or much better at least).

Comment 6

[David Durst [:ddurst]]

This appears to be resolved via https://github.com/cpriest/SnapLinksPlus/issues/280.

:robwu, I'll leave it to you to close if appropriate.