1474808 - MediaPipeline::SetTransport doesn't always set mDescription

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, enhancement, P3)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

SetTransport bails early if there is no DOM Track[0], and does not set mDescription. It should probably set mDescription.

[0] https://searchfox.org/mozilla-central/source/media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp#1393

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=329dcf9139b608f011897e6a0176da27b0aa0aa1

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1474808 - MediaPipeline set description even when there is no DOM Track

Early bailout was preventing mDescription from getting set in MediaPipeline::SetTransport.

Review commit: https://reviewboard.mozilla.org/r/256180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256180/

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8991221 [details]
Bug 1474808 - MediaPipeline set description even when there is no DOM Track

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256180/diff/1-2/

Comment 4

[Byron Campen [:bwc]]

Comment on attachment 8991221 [details]
Bug 1474808 - MediaPipeline set description even when there is no DOM Track

https://reviewboard.mozilla.org/r/256180/#review263538

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64fe39155063
MediaPipeline set description even when there is no DOM Track r=bwc

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/64fe39155063