1474836 - Font editor: do not invoke on pseudo-elements

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Razvan Caliman [:rcaliman]]

As long as property value changes are written exclusively to the selected element's inline style attribute, pseudo-elements cannot be supported by the font editor.

When a pseudo-element like ::before or ::after is selected, show the font editor empty state with a warning message with the reason.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1474836 - (Part 1) Externalize font editor empty state warning message to Redux store.

Review commit: https://reviewboard.mozilla.org/r/256196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256196/

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1474836 - (Part 2) Show editor empty state with custom warning for pseudo-elements.

Review commit: https://reviewboard.mozilla.org/r/256198/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256198/

Comment 3

[Code Review Bot [:reviewbot]]

Comment on attachment 8991240 [details]
Bug 1474836 - (Part 1) Externalize font editor empty state warning message to Redux store.

https://reviewboard.mozilla.org/r/256196/#review263060


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/inspector/fonts/fonts.js:34
(Diff revision 1)
>    resetFontEditor,
>    updateAxis,
>    updateCustomInstance,
>    updateFontEditor,
>    updateFontProperty,
> +  updateWarningMessage,

Error: 'updateWarningMessage' is assigned a value but never used. [eslint: no-unused-vars]

Comment 4

[Razvan Caliman [:rcaliman]]

Comment on attachment 8991240 [details]
Bug 1474836 - (Part 1) Externalize font editor empty state warning message to Redux store.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256196/diff/1-2/

Comment 5

[Razvan Caliman [:rcaliman]]

Comment on attachment 8991241 [details]
Bug 1474836 - (Part 2) Show editor empty state with custom warning for pseudo-elements.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256198/diff/1-2/

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8991241 [details]
Bug 1474836 - (Part 2) Show editor empty state with custom warning for pseudo-elements.

https://reviewboard.mozilla.org/r/256198/#review263116

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8991240 [details]
Bug 1474836 - (Part 1) Externalize font editor empty state warning message to Redux store.

https://reviewboard.mozilla.org/r/256196/#review263118

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a357b54899d
(Part 1) Externalize font editor empty state warning message to Redux store. r=gl
https://hg.mozilla.org/integration/autoland/rev/e4d608a4a833
(Part 2) Show editor empty state with custom warning for pseudo-elements. r=gl

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0a357b54899d
https://hg.mozilla.org/mozilla-central/rev/e4d608a4a833