Closed Bug 1474849 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 11907 - Correctly initialize and test SnapContainerData in cc.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 11907 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11907
Details from upstream follow.

Sandra Sun <sunyunjia@chromium.org> wrote:
>  Correctly initialize and test SnapContainerData in cc.
>  
>  This patch initializes the rect_ field in SnapContainerData in copy
>  constructor and move constructor. Fixing a snapping issue in the
>  composited pages.
>  
>  We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
>  test suite so that they are tested with the composited cases.
>  
>  snap-at-user-scroll-end-manual-automation.js calls
>  mouseClickInTarget() of pointerevent_common_input.js. That method
>  invokes programmatic scrolls. The test was written before programmatic
>  scroll snapping was implemented so it worked at that time. However,
>  with programmatic scroll snapping implemented, it will always snap
>  in mouseClickIntarget() and cannot test whether the user scroll snaps.
>  This patch writes it own version of clickButton() to avoid invoking
>  programmatic scrolls in the test.
>  
>  Bug: 862406
>  Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
>  Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
>  Reviewed-on: https://chromium-review.googlesource.com/1132386
>  WPT-Export-Revision: d8310d17cf7de101408bd2b2da82c97a1ae536dd
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1763bbeb8210
[wpt PR 11907] - Correctly initialize and test SnapContainerData in cc., a=testonly
https://hg.mozilla.org/mozilla-central/rev/1763bbeb8210
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.