Closed
Bug 1474981
Opened 6 years ago
Closed 6 years ago
Search engine can't be loaded from AMO (favicon problem)
Categories
(Firefox :: Search, defect, P1)
Firefox
Search
Tracking
()
VERIFIED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox-esr60 | --- | unaffected |
| firefox61 | --- | unaffected |
| firefox62 | --- | unaffected |
| firefox63 | + | verified |
| firefox64 | --- | verified |
People
(Reporter: mkaply, Assigned: mossop)
References
Details
(Keywords: regression)
Attachments
(2 files)
Bug1474981.png
If you go to a search engine on AMO: https://addons.mozilla.org/en-US/firefox/addon/tv-tropes-94107/?src=search and try to add it, you get: TypeError: tabbrowser.shouldLoadFavIcon is not a function[Learn More] MainProcessSingleton.js:26:45 on the console. Tracked this down to a regression from bug 1453751
|
Reporter | |
Updated•6 years ago
|
Flags: needinfo?(dtownsend)
|
||
Updated•6 years ago
|
Component: Tabbed Browser → Search
|
||
Updated•6 years ago
|
Keywords: regression
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → dtownsend
Flags: needinfo?(dtownsend)
|
|
Reporter | |
Updated•6 years ago
|
Priority: -- → P1
|
||
Updated•6 years ago
|
tracking-firefox63:
--- → +
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8991941 [details] Bug 1474981: Allow newly added search engines to use the tab icon if it is a data uri. Mike de Boer [:mikedeboer] has approved the revision. https://phabricator.services.mozilla.com/D2123
Attachment #8991941 -
Flags: review+
Pushed by dtownsend@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/977302799d70 Allow newly added search engines to use the tab icon if it is a data uri. r=mikedeboer
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/977302799d70
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
|
||
Updated•6 years ago
|
status-firefox61:
--- → unaffected
status-firefox62:
--- → unaffected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
I was able to reproduce this issue on Firefox 63.0a1(20180711100118) under Win 7 64-bit and Mac OS X 10.13.3. This issue is verified as fixed on Firefox 64.0a1(20180916220033) and Firefox 63.0b6(20180913141435) under Win 7 64-bit and Mac OS X 10.13.3. Please see the attached screenshot.
You need to log in
before you can comment on or make changes to this bug.
Description
•