Closed Bug 1474990 Opened 2 years ago Closed 2 years ago

Remove Memory.jsm and the 'Memory usage of Subprocesses' table from about:performance

Categories

(Toolkit :: Performance Monitoring, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

The values provided in this table are not useful for users as the break down is by process id, rather than by tab.

Also, the data collection system used to update the information displayed there is causing jank.

These 2 points lead me to the conclusion that we should remove this section from about:performance.

We are hoping to introduce a low overhead way to record memory allocations per tab in bug 1450363, which should be a basis for a better replacement.
Attached patch Removal patchSplinter Review
Attachment #8991575 - Flags: review?(mconley)
Comment on attachment 8991575 [details] [diff] [review]
Removal patch

Review of attachment 8991575 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is fine to remove, so long as we're getting a replacement soon-ish.

I'm also cc'ing erahm about this bug, since I think this will affect bug 1296898 (which hasn't had much movement, but still wanted to highlight the connection).
Attachment #8991575 - Flags: review?(mconley) → review+
See Also: → 1296898
Summary: Remove the 'Memory usage of Subprocesses' table from about:performance → Remove Memory.jsm and the 'Memory usage of Subprocesses' table from about:performance
(In reply to Mike Conley (:mconley) (:⚙️) (PTO Jul 24th-Aug 6th)) from comment #2)
> Comment on attachment 8991575 [details] [diff] [review]
> Removal patch
> 
> Review of attachment 8991575 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think this is fine to remove, so long as we're getting a replacement
> soon-ish.
> 
> I'm also cc'ing erahm about this bug, since I think this will affect bug
> 1296898 (which hasn't had much movement, but still wanted to highlight the
> connection).

Thanks for the heads up. Ideally I'd like to keep Memory.jsm for bug 1296898 (which now that I reminded of it I can put a bit more effort into).
(In reply to Eric Rahm [:erahm] from comment #3)

> Ideally I'd like to keep Memory.jsm for bug 1296898

I discussed this with Eric over IRC, he's fine with me removing it for now (to avoid it being detected as unreferenced code), and just asked that I provide a link to the removal hg changeset in bug 1296898 for easy future reference.
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ee592ecc6ac
Remove the 'Memory usage of Subprocesses' table from about:performance, r=mconley.
https://hg.mozilla.org/mozilla-central/rev/6ee592ecc6ac
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.