1475003 - Assertion failure: (last == doc) == wasInComposedDoc || (IsRemoveNotification::No == IsRemoveNotification::Yes && !strcmp("AttributeWillChange", "NativeAnonymousChildListChange")), at src/dom/base/nsNodeUtils.cpp:159

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.html

Reduced with m-c:
BuildID=20180711094246
SourceStamp=aff060ad3204234adae2d59b3776207c6687ebfc

Assertion failure: (last == doc) == wasInComposedDoc || (IsRemoveNotification::No == IsRemoveNotification::Yes && !strcmp("AttributeWillChange", "NativeAnonymousChildListChange")), at src/dom/base/nsNodeUtils.cpp:159

0|0|libxul.so|nsNodeUtils::AttributeWillChange(mozilla::dom::Element*, int, nsAtom*, int, nsAttrValue const*)|hg:hg.mozilla.org/mozilla-central:dom/base/nsNodeUtils.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|157|0x18
0|1|libxul.so|nsStyledElement::InlineStyleDeclarationWillChange(mozilla::MutationClosureData&)|hg:hg.mozilla.org/mozilla-central:dom/base/nsStyledElement.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|108|0xd
0|2|libxul.so|_ZN10geckoservo4glue15remove_property17ha7700602e1a3bdccE|hg:hg.mozilla.org/mozilla-central:servo/ports/geckolib/glue.rs:aff060ad3204234adae2d59b3776207c6687ebfc|177|0x6
0|3|libxul.so|Servo_DeclarationBlock_RemovePropertyById|hg:hg.mozilla.org/mozilla-central:servo/ports/geckolib/glue.rs:aff060ad3204234adae2d59b3776207c6687ebfc|3721|0xe
0|4|libxul.so|nsDOMCSSDeclaration::RemovePropertyInternal(nsCSSPropertyID)|hg:hg.mozilla.org/mozilla-central:layout/style/DeclarationBlock.h:aff060ad3204234adae2d59b3776207c6687ebfc|223|0x24
0|5|libxul.so|nsSMILCompositor::ClearAnimationEffects()|hg:hg.mozilla.org/mozilla-central:dom/smil/nsSMILCompositor.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|131|0x11
0|6|libxul.so|nsSMILAnimationController::DoSample(bool)|hg:hg.mozilla.org/mozilla-central:dom/smil/nsSMILAnimationController.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|428|0x8
0|7|libxul.so|nsSMILTimeContainer::Sample()|hg:hg.mozilla.org/mozilla-central:dom/smil/nsSMILTimeContainer.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|185|0x9
0|8|libxul.so|nsSMILAnimationController::AddChild(nsSMILTimeContainer&)|hg:hg.mozilla.org/mozilla-central:dom/smil/nsSMILAnimationController.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|765|0x8
0|9|libxul.so|mozilla::dom::SVGSVGElement::BindToTree(nsIDocument*, nsIContent*, nsIContent*, bool)|hg:hg.mozilla.org/mozilla-central:dom/svg/SVGSVGElement.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|499|0x1a
0|10|libxul.so|mozilla::dom::Element::BindToTree(nsIDocument*, nsIContent*, nsIContent*, bool)|hg:hg.mozilla.org/mozilla-central:dom/base/Element.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|1767|0x19
0|11|libxul.so|nsGenericHTMLElement::BindToTree(nsIDocument*, nsIContent*, nsIContent*, bool)|hg:hg.mozilla.org/mozilla-central:dom/html/nsGenericHTMLElement.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|426|0x5
0|12|libxul.so|mozilla::dom::Element::BindToTree(nsIDocument*, nsIContent*, nsIContent*, bool)|hg:hg.mozilla.org/mozilla-central:dom/base/Element.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|1767|0x19
0|13|libxul.so|nsGenericHTMLElement::BindToTree(nsIDocument*, nsIContent*, nsIContent*, bool)|hg:hg.mozilla.org/mozilla-central:dom/html/nsGenericHTMLElement.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|426|0x5
0|14|libxul.so|nsINode::doInsertChildAt(nsIContent*, unsigned int, bool, nsAttrAndChildArray&)|hg:hg.mozilla.org/mozilla-central:dom/base/nsINode.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|1391|0x15
0|15|libxul.so|nsINode::ReplaceOrInsertBefore(bool, nsINode*, nsINode*, mozilla::ErrorResult&)|hg:hg.mozilla.org/mozilla-central:dom/base/nsINode.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|2281|0x17
0|16|libxul.so|mozilla::dom::Node_Binding::appendChild|hg:hg.mozilla.org/mozilla-central:dom/base/nsINode.h:aff060ad3204234adae2d59b3776207c6687ebfc|1780|0x12
0|17|libxul.so|bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*)|hg:hg.mozilla.org/mozilla-central:dom/bindings/BindingUtils.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|3306|0x9
0|18|libxul.so|CallJSNative(JSContext*, bool (*)(JSContext*, unsigned int, JS::Value*), JS::CallArgs const&)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|444|0x3
0|19|libxul.so|js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|532|0xf
0|20|libxul.so|InternalCall|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|583|0xd
0|21|libxul.so|Interpret|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|589|0xf
0|22|libxul.so|js::RunScript(JSContext*, js::RunState&)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|424|0xb
0|23|libxul.so|js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|556|0xf
0|24|libxul.so|InternalCall|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|583|0xd
0|25|libxul.so|js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>)|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|602|0x5
0|26|libxul.so|JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>)|hg:hg.mozilla.org/mozilla-central:js/src/jsapi.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|2887|0x20
0|27|libxul.so|mozilla::dom::FrameRequestCallback::Call(JSContext*, JS::Handle<JS::Value>, double, mozilla::ErrorResult&)|s3:gecko-generated-sources:4fce2dd7ee587556c514cd2c1b5b02318d3e2f1baab39bf91bc6f021bb673a612249967d3bc70549b0dec0227daf82ed1f7d5044045e6eaa16c5b82229566f6e/dom/bindings/WindowBinding.cpp:|805|0x5
0|28|libxul.so|nsRefreshDriver::RunFrameRequestCallbacks(mozilla::TimeStamp)|s3:gecko-generated-sources:4d187dc77b9f2b5411b20d21b8b40d31947ad8782c05c10f81b8d643c5ba64653a267ae22323eb944f7fc263a9cec06a815db15e101451ca54a74c915d707475/dist/include/mozilla/dom/WindowBinding.h:|548|0x1a
0|29|libxul.so|nsRefreshDriver::Tick(long, mozilla::TimeStamp)|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|1919|0xf
0|30|libxul.so|mozilla::RefreshDriverTimer::TickRefreshDrivers(long, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&)|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|303|0xb
0|31|libxul.so|mozilla::RefreshDriverTimer::Tick(long, mozilla::TimeStamp)|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|322|0xf
0|32|libxul.so|mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::TimeStamp)|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|767|0x5
0|33|libxul.so|mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyVsync(mozilla::TimeStamp)|hg:hg.mozilla.org/mozilla-central:layout/base/nsRefreshDriver.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|579|0xc
0|34|libxul.so|mozilla::layout::VsyncChild::RecvNotify(mozilla::TimeStamp const&)|hg:hg.mozilla.org/mozilla-central:layout/ipc/VsyncChild.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|68|0x9
0|35|libxul.so|mozilla::layout::PVsyncChild::OnMessageReceived(IPC::Message const&)|s3:gecko-generated-sources:0c7cf777c2ff93c34ff1546f677320cb1229427e6947e87c6fa76720f9b9c5b6a4a4d036521ed9a643f4fa5e10a57d8748e2532d47fce8282aa653340c0c00ff/ipc/ipdl/PVsyncChild.cpp:|167|0xc
0|36|libxul.so|mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessageChannel.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|2134|0x6
0|37|libxul.so|mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessageChannel.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|2064|0xb
0|38|libxul.so|mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessageChannel.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|1910|0xb
0|39|libxul.so|mozilla::ipc::MessageChannel::MessageTask::Run()|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessageChannel.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|1943|0xc
0|40|libxul.so|nsThread::ProcessNextEvent(bool, bool*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|1051|0x15
0|41|libxul.so|NS_ProcessNextEvent(nsIThread*, bool)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|519|0x11
0|42|libxul.so|mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|125|0xd
0|43|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:aff060ad3204234adae2d59b3776207c6687ebfc|325|0x17
0|44|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:aff060ad3204234adae2d59b3776207c6687ebfc|318|0x8
0|45|libxul.so|nsBaseAppShell::Run()|hg:hg.mozilla.org/mozilla-central:widget/nsBaseAppShell.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|158|0xd
0|46|libxul.so|XRE_RunAppShell()|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|920|0x11
0|47|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|269|0x5
0|48|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:aff060ad3204234adae2d59b3776207c6687ebfc|325|0x17
0|49|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:aff060ad3204234adae2d59b3776207c6687ebfc|318|0x8
0|50|libxul.so|XRE_InitChildProcess(int, char**, XREChildData const*)|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|746|0x8
0|51|firefox|content_process_main(mozilla::Bootstrap*, int, char**)|hg:hg.mozilla.org/mozilla-central:ipc/contentproc/plugin-container.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|50|0x14
0|52|firefox|main|hg:hg.mozilla.org/mozilla-central:browser/app/nsBrowserApp.cpp:aff060ad3204234adae2d59b3776207c6687ebfc|287|0x11
0|53|libc-2.23.so||||0x20830
0|54|firefox|MOZ_ReportAssertionFailure|hg:hg.mozilla.org/mozilla-central:mfbt/Assertions.h:aff060ad3204234adae2d59b3776207c6687ebfc|164|0x5

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

More like SVG doing something unexpected. Looking this a bit.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This is my regression.
We used to have
https://dxr.mozilla.org/mozilla-beta/rev/fc0a1b63ccc727f9cb4ed424d3ac88e86529fc46/layout/style/nsDOMCSSAttrDeclaration.cpp#116

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: smil_attr_crash.diff

We should not notify about smil attr changes.

remote:   https://hg.mozilla.org/try/rev/80c623661ef25e7976119d1690cab00356d9ecda
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=80c623661ef25e7976119d1690cab00356d9ecda
remote: recorded changegroup in replication log in 0.113s

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2379329b1413
don't notify DOM of SMIL changes, r=peterv

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2379329b1413