1475024 - Add Stringify overloads for RectAbsolute

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

Stringify(foo) works when foo is an nsRect but not when it's an nsRectAbsolute.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1475024 - Add Stringify overloads for RectAbsolute.

Review commit: https://reviewboard.mozilla.org/r/256332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256332/

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8991431 [details]
Bug 1475024 - Add Stringify overloads for RectAbsolute.

https://reviewboard.mozilla.org/r/256332/#review263598

::: gfx/layers/LayersLogging.h:114
(Diff revision 1)
> +               const char* pfx="", const char* sfx="")
> +{
> +  aStream << pfx;
> +  aStream << nsPrintfCString(
> +    "(l=%f, t=%f, r=%f, b=%f)",
> +    r.X(), r.Y(), r.XMost(), r.YMost()).get();

nit: Do you mind using the new Left/Right/Top/Bottom accessors I added recently? I find they're a little bit more generic terms than X and XMost/etc. If you'd prefer not to that's fine as well.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Makes sense, I've updated the patch.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8991431 [details]
Bug 1475024 - Add Stringify overloads for RectAbsolute.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256332/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8f40ce410cb
Add Stringify overloads for RectAbsolute. r=bas

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a8f40ce410cb