Closed Bug 1475065 Opened 2 years ago Closed 2 years ago

Remove nsIDOMOfflineResourceList

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(13 files)

6.26 KB, patch
Nika
: review+
Details | Diff | Splinter Review
3.83 KB, patch
Nika
: review+
Details | Diff | Splinter Review
4.00 KB, patch
Nika
: review+
Details | Diff | Splinter Review
4.01 KB, patch
Nika
: review+
Details | Diff | Splinter Review
5.47 KB, patch
Nika
: review+
Details | Diff | Splinter Review
4.04 KB, patch
Nika
: review+
Details | Diff | Splinter Review
10.70 KB, patch
Nika
: review+
Details | Diff | Splinter Review
3.82 KB, patch
Nika
: review+
Details | Diff | Splinter Review
3.08 KB, patch
Nika
: review+
Details | Diff | Splinter Review
4.27 KB, patch
Nika
: review+
Details | Diff | Splinter Review
1.70 KB, patch
Nika
: review+
Details | Diff | Splinter Review
10.22 KB, patch
Nika
: review+
Details | Diff | Splinter Review
7.59 KB, patch
Nika
: review+
Details | Diff | Splinter Review
No description provided.
This incidentally fixes the indexed getter to not throw on out of bounds access
and instead to return undefined.
Attachment #8991531 - Flags: review?(nika)
Priority: -- → P2
Attachment #8991528 - Flags: review?(nika) → review+
Attachment #8991529 - Flags: review?(nika) → review+
Attachment #8991530 - Flags: review?(nika) → review+
Attachment #8991531 - Flags: review?(nika) → review+
Attachment #8991532 - Flags: review?(nika) → review+
Attachment #8991533 - Flags: review?(nika) → review+
Attachment #8991534 - Flags: review?(nika) → review+
Attachment #8991535 - Flags: review?(nika) → review+
Attachment #8991536 - Flags: review?(nika) → review+
Attachment #8991537 - Flags: review?(nika) → review+
Attachment #8991538 - Flags: review?(nika) → review+
Attachment #8991539 - Flags: review?(nika) → review+
Comment on attachment 8991540 [details] [diff] [review]
part 13.  Remove nsIDOMOfflineResourceList

Review of attachment 8991540 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #8991540 - Flags: review?(nika) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbdd71e2a0e1
part 1.  Remove JS consumers of nsIDOMOfflineResourceList.  r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/227cc1eb79d8
part 2.  Remove nsIDOMOfflineResourceList::MozHasItem.  r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/585577d78eaa
part 3.  Remove nsIDOMOfflineResourceList::GetMozLength.  r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae2211abd6c5
part 4.  Remove nsIDOMOfflineResourceList::MozItem.  r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/26b13a6fcc1c
part 5.  Remove nsIDOMOfflineResourceList::MozAdd.  r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e9c035c63c5
part 6.  Remove nsIDOMOfflineResourceList::MozRemove.  r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/c793ba5d3465
part 7.  Remove nsIDOMOfflineResourceList constants.  r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/599eb771566f
part 8.  Remove nsIDOMOfflineResourceList::GetStatus.  r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/e104628b0fcb
part 9.  Remove nsIDOMOfflineResourceList::Update.  r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/a073323b8dd7
part 10.  Remove nsIDOMOfflineResourceList::SwapCache.  r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/5994de98ae96
part 11.  Remove unused nsIDOMOfflineResourceList::GetMozItems.  r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/c063d5e6da85
part 12.  Stop using nsIDOMOfflineResourceList in bindings.  r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/59aec6da844c
part 13.  Remove nsIDOMOfflineResourceList.  r=nika
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.