Closed
Bug 1475065
Opened 6 years ago
Closed 6 years ago
Remove nsIDOMOfflineResourceList
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(13 files)
|
6.26 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
3.83 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
4.00 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
4.01 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
5.47 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
4.04 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
10.70 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
3.82 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
3.08 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
4.27 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
1.70 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
10.22 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
|
7.59 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8991528 -
Flags: review?(nika)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #8991529 -
Flags: review?(nika)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Attachment #8991530 -
Flags: review?(nika)
|
|
Assignee | |
Comment 4•6 years ago
|
||
This incidentally fixes the indexed getter to not throw on out of bounds access and instead to return undefined.
Attachment #8991531 -
Flags: review?(nika)
|
|
Assignee | |
Comment 5•6 years ago
|
||
Attachment #8991532 -
Flags: review?(nika)
|
|
Assignee | |
Comment 6•6 years ago
|
||
Attachment #8991533 -
Flags: review?(nika)
|
|
Assignee | |
Comment 7•6 years ago
|
||
Attachment #8991534 -
Flags: review?(nika)
|
|
Assignee | |
Comment 8•6 years ago
|
||
Attachment #8991535 -
Flags: review?(nika)
|
|
Assignee | |
Comment 9•6 years ago
|
||
Attachment #8991536 -
Flags: review?(nika)
|
|
Assignee | |
Comment 10•6 years ago
|
||
Attachment #8991537 -
Flags: review?(nika)
|
|
Assignee | |
Comment 11•6 years ago
|
||
Attachment #8991538 -
Flags: review?(nika)
|
|
Assignee | |
Comment 12•6 years ago
|
||
Attachment #8991539 -
Flags: review?(nika)
|
|
Assignee | |
Comment 13•6 years ago
|
||
Attachment #8991540 -
Flags: review?(nika)
|
||
Updated•6 years ago
|
Priority: -- → P2
|
||
Updated•6 years ago
|
Attachment #8991528 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #8991529 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #8991530 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #8991531 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #8991532 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #8991533 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #8991534 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #8991535 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #8991536 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #8991537 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #8991538 -
Flags: review?(nika) → review+
|
|
||
Updated•6 years ago
|
Attachment #8991539 -
Flags: review?(nika) → review+
|
|
||
Comment 14•6 years ago
|
||
Comment on attachment 8991540 [details] [diff] [review] part 13. Remove nsIDOMOfflineResourceList Review of attachment 8991540 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #8991540 -
Flags: review?(nika) → review+
|
|
||
Comment 15•6 years ago
|
||
|
||
Comment 16•6 years ago
|
||
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bbdd71e2a0e1 part 1. Remove JS consumers of nsIDOMOfflineResourceList. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/227cc1eb79d8 part 2. Remove nsIDOMOfflineResourceList::MozHasItem. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/585577d78eaa part 3. Remove nsIDOMOfflineResourceList::GetMozLength. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/ae2211abd6c5 part 4. Remove nsIDOMOfflineResourceList::MozItem. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/26b13a6fcc1c part 5. Remove nsIDOMOfflineResourceList::MozAdd. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/1e9c035c63c5 part 6. Remove nsIDOMOfflineResourceList::MozRemove. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/c793ba5d3465 part 7. Remove nsIDOMOfflineResourceList constants. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/599eb771566f part 8. Remove nsIDOMOfflineResourceList::GetStatus. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/e104628b0fcb part 9. Remove nsIDOMOfflineResourceList::Update. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/a073323b8dd7 part 10. Remove nsIDOMOfflineResourceList::SwapCache. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/5994de98ae96 part 11. Remove unused nsIDOMOfflineResourceList::GetMozItems. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/c063d5e6da85 part 12. Stop using nsIDOMOfflineResourceList in bindings. r=nika https://hg.mozilla.org/integration/mozilla-inbound/rev/59aec6da844c part 13. Remove nsIDOMOfflineResourceList. r=nika
|
||
Comment 17•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bbdd71e2a0e1 https://hg.mozilla.org/mozilla-central/rev/227cc1eb79d8 https://hg.mozilla.org/mozilla-central/rev/585577d78eaa https://hg.mozilla.org/mozilla-central/rev/ae2211abd6c5 https://hg.mozilla.org/mozilla-central/rev/26b13a6fcc1c https://hg.mozilla.org/mozilla-central/rev/1e9c035c63c5 https://hg.mozilla.org/mozilla-central/rev/c793ba5d3465 https://hg.mozilla.org/mozilla-central/rev/599eb771566f https://hg.mozilla.org/mozilla-central/rev/e104628b0fcb https://hg.mozilla.org/mozilla-central/rev/a073323b8dd7 https://hg.mozilla.org/mozilla-central/rev/5994de98ae96 https://hg.mozilla.org/mozilla-central/rev/c063d5e6da85 https://hg.mozilla.org/mozilla-central/rev/59aec6da844c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•