Bootstrap process: Faster processing of UNICODE_STRINGs in blocklist

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P1
normal
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: aklotz, Assigned: aklotz)

Tracking

(Blocks 1 bug)

Trunk
Firefox 63
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: inj+)

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
I've noticed a couple of areas where we can accelerate our handling of UNICODE_STIRNGs:

1. Specify the bootstrap blocklist in terms of literal UNICODE_STRINGs instead of wide string literals; this allows us to drop the RtlInitUnicodeString which must essentially do a wcslen to determine the length.

2. Modify the checks for special DLL names to fail if the input string is too short to possibly pass the check.
(Assignee)

Comment 1

10 months ago
Attachment #8991471 - Flags: review?(mhowell)
Attachment #8991471 - Flags: review?(mhowell) → review+
(Assignee)

Updated

10 months ago
Keywords: checkin-needed

Comment 2

10 months ago
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de4058a2b443
Faster handling of UNICODE_STRINGs in bootstrap blocklist; r=mhowell
Keywords: checkin-needed

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/de4058a2b443
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.