Closed
Bug 1475067
Opened 6 years ago
Closed 6 years ago
Bootstrap process: Faster processing of UNICODE_STRINGs in blocklist
Categories
(Firefox :: General, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: inj+)
Attachments
(1 file)
|
10.90 KB,
patch
|
molly
:
review+
|
Details | Diff | Splinter Review |
I've noticed a couple of areas where we can accelerate our handling of UNICODE_STIRNGs: 1. Specify the bootstrap blocklist in terms of literal UNICODE_STRINGs instead of wide string literals; this allows us to drop the RtlInitUnicodeString which must essentially do a wcslen to determine the length. 2. Modify the checks for special DLL names to fail if the input string is too short to possibly pass the check.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8991471 -
Flags: review?(mhowell)
|
||
Updated•6 years ago
|
Attachment #8991471 -
Flags: review?(mhowell) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/de4058a2b443 Faster handling of UNICODE_STRINGs in bootstrap blocklist; r=mhowell
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0897ce4b7307867286eb4d4b178118cddea528ff
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/de4058a2b443
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•