Closed Bug 1475067 Opened 2 years ago Closed 2 years ago

Bootstrap process: Faster processing of UNICODE_STRINGs in blocklist

Categories

(Firefox :: General, enhancement, P1)

Unspecified
Windows
enhancement

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

(Blocks 1 open bug)

Details

(Whiteboard: inj+)

Attachments

(1 file)

I've noticed a couple of areas where we can accelerate our handling of UNICODE_STIRNGs:

1. Specify the bootstrap blocklist in terms of literal UNICODE_STRINGs instead of wide string literals; this allows us to drop the RtlInitUnicodeString which must essentially do a wcslen to determine the length.

2. Modify the checks for special DLL names to fail if the input string is too short to possibly pass the check.
Attachment #8991471 - Flags: review?(mhowell)
Attachment #8991471 - Flags: review?(mhowell) → review+
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de4058a2b443
Faster handling of UNICODE_STRINGs in bootstrap blocklist; r=mhowell
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/de4058a2b443
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.