Closed Bug 1475194 Opened 6 years ago Closed 6 years ago

failed to run wpt test in test-verify-backfill due to missing --gpu-required

Categories

(Testing :: General, defect, P1)

defect

Tracking

(firefox-esr60 fixed, firefox62 fixed, firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr60 --- fixed
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: jmaher, Assigned: gbrown)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

my understanding is that we don't run any wpt tests on gpu instances, but on a recent run:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=win%20msvc%20opt%20tvw-bf&tochange=3edc9c3ae818490ed36b8bfc8ffdfc9e222b41db&fromchange=70f901964f9725e6dfd09750f48996e9d6670492&selectedJob=187785848

I see the failure as:
xecuting command 0: c:\mozilla-build\python\python.exe -u mozharness\scripts\web_platform_tests.py --cfg mozharness\configs\web_platform_tests\prod_config_windows_taskcluster.py --installer-url https://queue.taskcluster.net/v1/task/IHRfV5r_SPC8NcjL0AmgPA/artifacts/public/build/target.zip --test-packages-url https://queue.taskcluster.net/v1/task/IHRfV5r_SPC8NcjL0AmgPA/artifacts/public/build/target.test_packages.json --download-symbols ondemand --e10s --verify --total-chunk=1 --this-chunk=1 --gpu-required

Z:\task_1531388835>c:\mozilla-build\python\python.exe -u mozharness\scripts\web_platform_tests.py --cfg mozharness\configs\web_platform_tests\prod_config_windows_taskcluster.py --installer-url https://queue.taskcluster.net/v1/task/IHRfV5r_SPC8NcjL0AmgPA/artifacts/public/build/target.zip --test-packages-url https://queue.taskcluster.net/v1/task/IHRfV5r_SPC8NcjL0AmgPA/artifacts/public/build/target.test_packages.json --download-symbols ondemand --e10s --verify --total-chunk=1 --this-chunk=1 --gpu-required 
Usage: web_platform_tests.py [options]

web_platform_tests.py: error: no such option: --gpu-required
:gbrown, would this be fallout from your fix of the str->bool type for gpu_required?
Flags: needinfo?(gbrown)
I wonder...will have a look.
Assignee: nobody → gbrown
Flags: needinfo?(gbrown)
This failure is specific to backfill. Taskcluster configs use --gpu-required only for test-verify-gpu and test-coverage-gpu, which run desktop_unittest/android_emulator_unittest, where --gpu-required is recognized.

Backfill determines gpu-ness with:

                    if 'gpu' in task.task['metadata']['name'] or \
                       'webgl' in task.task['metadata']['name'] or \
                       'canvas' in tp or \
                       'gfx/tests' in tp or \
                       ('reftest' in tp and 'jsreftest' not in tp):
                        gpu_required = True

If a wpt test has "canvas" in the test path, for instance, backfill will specify --gpu-required, even if it is a web-platform test. I think we just need to exclude web-platform tests from gpu_required to avoid this.
I cannot find the requested test path in the log of comment 0, but I suspect we were backfilling the failed windows wpt test of that push: /service-workers/service-worker/fetch-canvas-tainting-image-cache.https.html -- containing "canvas".
I think this is correct, but I'm struggling to verify it on try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b94ff172933a221552f82c088587c2bdb07ab73

My wpt backfill did not run any tests. Maybe just my inexperience with backfilling...could you have a look?
Flags: needinfo?(jmaher)
Summary: failed to run wpt test in test-verify due to missing --gpu-required → failed to run wpt test in test-verify-backfill due to missing --gpu-required
Priority: -- → P1
yes, you need to add testing/web-platform/tests/

you had:
testPath: /service-workers/service-worker/fetch-canvas-tainting-image-cache.https.html

you need:
testPath: testing/web-platform/tests/service-workers/service-worker/fetch-canvas-tainting-image-cache.https.html
Flags: needinfo?(jmaher)
Thanks - that did the trick.

With correct testPath + my patch here, I can backfill fetch-canvas-tainting-image-cache.https.html.
Attachment #8991735 - Flags: review?(jmaher)
Comment on attachment 8991735 [details] [diff] [review]
do not use --gpu-required for TV-bf of wpt

Review of attachment 8991735 [details] [diff] [review]:
-----------------------------------------------------------------

this looks great.
Attachment #8991735 - Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3a9e9c8a7c7
In TV-bf, avoid use of --gpu-required for wpt; r=jmaher
Blocks: test-verify
https://hg.mozilla.org/mozilla-central/rev/a3a9e9c8a7c7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.