1475212 - The "Try It Now" and the "Start Browsing" onboarding overlay's buttons are not visibly focused using keyboard navigation

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:
- Firefox Beta 62.0b7

[Affected Platforms]:
- All Windows
- All Linux
- All Mac

[Prerequisites]:
- Have a new Firefox profile.
- Have the following prefs in the "about:config" page:
	- "browser.newtabpage.activity-stream.asrouterOnboardingCohort" pref set to "1" or "2";
	- "browser.newtabpage.activity-stream.feeds.snippets" is set to "true";
	- "browser.ping-centre.log" is set to "true"

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites and navigate to "about:welcome" page.
2. Skip the sign-in flow and press the "Tab" key.
3. Observe the behavior.

[Expected result]:
- The "Try It Now" button from the first onboarding card is focused.

[Actual result]:
- Nothing happens.

[Notes]:
- After following the steps from above, if the "Enter" key is pressed, the "about:addons" page is opened. 
- It seems that this issue is also reproducible on the latest Nightly build (63.0a1), the only difference is that the "about:newtab" page is focused instead of the onboarding overlay after the "Tab" key is pressed.
- This issue is also reproducible is the sign in flow is completed.
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4246

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/9cd4145dc607168c5110d0ee6314a0383b800103
Fix Bug 1475212 - Onboarding overlay's buttons are not visibly focused using keyboard navigation

https://github.com/mozilla/activity-stream/commit/6f362fbcf0259623be5e268b400b6fd2304d6657
Merge pull request #4246 from sarracini/bug_1475212

Fix Bug 1475212 - Onboarding overlay's buttons are not visibly focused using keyboard navigation

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/25850b8979c5

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue and it is no longer reproducible on Windows 10 x64, Arch Linux and Mac 10.13.3, with the latest Nightly build (63.0a1 Build ID - 20180719100142) installed. Now the "Try It Now" and the "Start Browsing" onboarding overlay's buttons are visibly focused when using keyboard navigation.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Ursula, is that something that you will uplift to beta?
Thanks

Comment 6

[Ursula Sarracini (:ursula)]

No I don't think it is necessary to uplift this. Thanks!