Closed Bug 1475213 Opened 6 years ago Closed 6 years ago

Missing services import in wcap module

Categories

(Calendar :: Provider: WCAP, enhancement)

Product:
Calendar
Component:
Provider: WCAP
Version:
Lightning 6.2
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file)

Fix - v1
1.12 KB, patch
Fallen
: review+
Fallen
: approval-calendar-beta+
Fallen
: approval-calendar-esr+
Details | Diff | Splinter Review 
Bug 1452120 regressed an issue where Services.jsm is not imported.
Attached patch Fix - v1 — — Splinter Review 
I'm going to go ahead and r=me on this one given the obviousness.
Attachment #8991592 - Flags: review+
Comment on attachment 8991592 [details] [diff] [review]
Fix - v1

This needs to go all the way to Lightning 6.2. Hope I got the flags right.
Attachment #8991592 - Flags: approval-calendar-esr+
Attachment #8991592 - Flags: approval-calendar-beta+
(In reply to Philipp Kewisch [:Fallen] from comment #1)
> I'm going to go ahead and r=me on this one given the obviousness.
That's the way ;-)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/104061b17954
Missing services import in the WCAP Module. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.5
(In reply to Philipp Kewisch [:Fallen] from comment #2)
> This needs to go all the way to Lightning 6.2. Hope I got the flags right.
Yes. Since we're not shipping another TB 60 beta, I'll uplift once the TB 60 ESR code is ready, also to TB 62 beta.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: