1475215 - Default Firefox Nightly theme becomes a dark theme after switching in customize panel

Status: RESOLVED DUPLICATE of bug 1474591

(Firefox :: Toolbars and Customization, defect, P1)

Description

[[e-mail]]

Attachment: 2 png screens-in-one for a proof

Default FirefoxNightly (63.0a1 2018-07-11) theme becomes a dark theme after switching in customize panel
I can't choose the default Firefox Nightly theme even if I restore default settings in customize panel.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

[Tracking Requested - why for this release]: new feature in 63 (introduced by bug 1368808), we should make sure that we fix any confusion around it before it gets released.

Gadzillos, do you have Windows set to use a dark theme? This is enabled by going to the Personalize -> Colors -> Choose your default app mode and choosing Dark.

This is most likely from bug 1368808. In my testing of this, we show a preview of the Default (light on dark) theme when hovering over the Default item within Customize mode but clicking on it will use the Dark theme.

We shouldn't be showing the "light on dark" default theme during the preview, and possibly we may want to add some kind of string that says that the Default theme is using Dark based on system preferences.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

shorlander, what do you think about adding a string like I proposed in comment 1? I'm not sure where it would fit.

Comment 3

[Dão Gottwald [:dao]]

This appears to be the same as bug 1474591. Let's not spread the discussion across multiple bugs.

Comment 4

[Pascal Chevrel (relman team) -> :pascalc]

Not tracking this one as we already track bug 1474591 for 63