Closed
Bug 1475220
Opened 6 years ago
Closed 6 years ago
Cleanup a bit push_applicable_declarations.
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
|
7.57 KB,
patch
|
xidorn
:
review+
|
Details | Diff | Splinter Review |
Now that !important is handled elsewhere we can cleanup getDefaultComputedStyle a bit.
|
Assignee | |
Comment 1•6 years ago
|
||
Sorry for not using phabricator, but terrible internet :)
Attachment #8991600 -
Flags: review?(xidorn+moz)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8991600 [details] [diff] [review] Cleanup push_applicable_declarations. Review of attachment 8991600 [details] [diff] [review]: ----------------------------------------------------------------- So this patch changes the behavior to skipping XBL rules for getDefaultComputedStyle. This should probably be mentioned in the commit message. Also you should probably remove your FIXME comment above that piece of code.
Attachment #8991600 -
Flags: review?(xidorn+moz) → review+
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/610ab76d2f80 Cleanup push_applicable_declarations. r=xidorn
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/610ab76d2f80
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•