Closed Bug 1475245 Opened 2 years ago Closed 2 years ago

Remove some unused/test-only functions on nsIAnnotationService

Categories

(Toolkit :: Places, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

nsIAnnotationService has some functions that are currently unused, so we can just remove them:

getPageAnnotationType
getItemAnnotationType
removePageAnnotations
removeItemAnnotations
pageHasAnnotation

There are also two that are currently test-only:

getPagesWithAnnotation
getItemsWithAnnotation

I decided that getPagesWithAnnotation could be re-implemented as a helper function in tests. I almost left getItemsWithAnnotation as it was (given we'll want to remove it in the future), but in the end decided we might as well move it to a helper function as well to be consistent.
Comment on attachment 8991631 [details]
Bug 1475245 - Remove some unused/test-only functions on nsIAnnotationService.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2098
Attachment #8991631 - Flags: review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4aa632ebb77
Remove some unused/test-only functions on nsIAnnotationService. r=mak
https://hg.mozilla.org/mozilla-central/rev/e4aa632ebb77
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.