1475245 - Remove some unused/test-only functions on nsIAnnotationService

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P1)

Description

[Mark Banner (:standard8)]

nsIAnnotationService has some functions that are currently unused, so we can just remove them:

getPageAnnotationType
getItemAnnotationType
removePageAnnotations
removeItemAnnotations
pageHasAnnotation

There are also two that are currently test-only:

getPagesWithAnnotation
getItemsWithAnnotation

I decided that getPagesWithAnnotation could be re-implemented as a helper function in tests. I almost left getItemsWithAnnotation as it was (given we'll want to remove it in the future), but in the end decided we might as well move it to a helper function as well to be consistent.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1475245 - Remove some unused/test-only functions on nsIAnnotationService.

MozReview-Commit-ID: LIIvA0eCpDI

Comment 2

[Phabricator Automation]

Comment on attachment 8991631 [details]
Bug 1475245 - Remove some unused/test-only functions on nsIAnnotationService.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2098

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4aa632ebb77
Remove some unused/test-only functions on nsIAnnotationService. r=mak

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e4aa632ebb77